WIP: action script #61
Annotations
1 error and 55 warnings
|
clippy
Clippy had exited with the 101 exit code
|
|
check-license
Config does not cover the file 'frame/liability/Cargo.toml'
|
|
check-license
Config does not cover the file 'frame/launch/Cargo.toml'
|
|
check-license
Config does not cover the file 'frame/digital-twin/Cargo.toml'
|
|
check-license
Config does not cover the file 'frame/datalog/Cargo.toml'
|
|
check-license
Config does not cover the file 'Dockerfile'
|
|
check-license
Config does not cover the file 'chains/polkadot-parachain.raw.json'
|
|
check-license
Config does not cover the file 'chains/kusama-parachain.raw.json'
|
|
check-license
Config does not cover the file 'chains/kusama-parachain.json'
|
|
check-license
Config does not cover the file 'Cargo.toml'
|
|
check-license
Config does not cover the file 'Cargo.lock'
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L418
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:418:26
|
418 | #[pallet::weight(100_000)]
| ^^^^^^^ help: omit the `let` binding: `100_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L390
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:390:26
|
390 | #[pallet::weight(100_000)]
| ^^^^^^^ help: omit the `let` binding: `100_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L371
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:371:26
|
371 | #[pallet::weight(100_000)]
| ^^^^^^^ help: omit the `let` binding: `100_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L349
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:349:26
|
349 | #[pallet::weight(100_000)]
| ^^^^^^^ help: omit the `let` binding: `100_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L306
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:306:26
|
306 | #[pallet::weight(100_000)]
| ^^^^^^^ help: omit the `let` binding: `100_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L419
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:419:16
|
419 | pub fn start_auction(
| ^^^^^^^^^^^^^ help: omit the `let` binding: `start_auction;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L391
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:391:16
|
391 | pub fn set_subscription(
| ^^^^^^^^^^^^^^^^ help: omit the `let` binding: `set_subscription;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L372
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:372:16
|
372 | pub fn set_oracle(
| ^^^^^^^^^^ help: omit the `let` binding: `set_oracle;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L350
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:350:16
|
350 | pub fn set_devices(
| ^^^^^^^^^^^ help: omit the `let` binding: `set_devices;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L307
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:307:16
|
307 | pub fn bid(
| ^^^ help: omit the `let` binding: `bid;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L275
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:275:16
|
275 | pub fn call(
| ^^^^ help: omit the `let` binding: `call;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
frame/rws/src/lib.rs#L471
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> frame/rws/src/lib.rs:471:60
|
471 | T::AuctionCurrency::slash_reserved(&subscription_id, auction.best_price);
| ^^^^^^^^^^^^^^^^ help: change this to: `subscription_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
redundant pattern matching, consider using `is_ok()`:
frame/rws/src/lib.rs#L437
warning: redundant pattern matching, consider using `is_ok()`
--> frame/rws/src/lib.rs:437:20
|
437 | if let Ok(_) = <AuctionQueue<T>>::mutate(|queue| queue.try_push(index.clone())) {
| -------^^^^^------------------------------------------------------------------- help: try: `if <AuctionQueue<T>>::mutate(|queue| queue.try_push(index.clone())).is_ok()`
|
= note: this will change drop order of the result, as well as all temporaries
= note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
= note: `#[warn(clippy::redundant_pattern_matching)]` on by default
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L423
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:423:13
|
423 | let _ = ensure_root(origin)?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `ensure_root(origin)?;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
= note: `#[warn(clippy::let_unit_value)]` on by default
|
|
using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait:
frame/rws/src/lib.rs#L334
warning: using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait
--> frame/rws/src/lib.rs:334:38
|
334 | auction.best_price = amount.clone();
| ^^^^^^^^^^^^^^ help: try removing the `clone` call: `amount`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
|
using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait:
frame/rws/src/lib.rs#L332
warning: using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait
--> frame/rws/src/lib.rs:332:54
|
332 | T::AuctionCurrency::reserve(&sender, amount.clone())?;
| ^^^^^^^^^^^^^^ help: try removing the `clone` call: `amount`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
|
using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait:
frame/rws/src/lib.rs#L328
warning: using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait
--> frame/rws/src/lib.rs:328:38
|
328 | auction.best_price = amount.clone();
| ^^^^^^^^^^^^^^ help: try removing the `clone` call: `amount`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
frame/rws/src/lib.rs#L326
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> frame/rws/src/lib.rs:326:47
|
326 | T::AuctionCurrency::unreserve(&winner, auction.best_price);
| ^^^^^^^ help: change this to: `winner`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait:
frame/rws/src/lib.rs#L325
10000
warning: using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait
--> frame/rws/src/lib.rs:325:54
|
325 | T::AuctionCurrency::reserve(&sender, amount.clone())?;
| ^^^^^^^^^^^^^^ help: try removing the `clone` call: `amount`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
|
this let-binding has unit value:
frame/digital-twin/src/lib.rs#L83
warning: this let-binding has unit value
--> frame/digital-twin/src/lib.rs:83:26
|
83 | #[pallet::weight(50_000)]
| ^^^^^^ help: omit the `let` binding: `50_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/digital-twin/src/lib.rs#L72
warning: this let-binding has unit value
--> frame/digital-twin/src/lib.rs:72:26
|
72 | #[pallet::weight(50_000)]
| ^^^^^^ help: omit the `let` binding: `50_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/digital-twin/src/lib.rs#L84
warning: this let-binding has unit value
--> frame/digital-twin/src/lib.rs:84:16
|
84 | pub fn set_source(
| ^^^^^^^^^^ help: omit the `let` binding: `set_source;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/digital-twin/src/lib.rs#L83
warning: use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/digital-twin/src/lib.rs:83:26
|
83 | #[pallet::weight(50_000)]
| ^^^^^^
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/digital-twin/src/lib.rs#L72
warning: use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/digital-twin/src/lib.rs:72:26
|
72 | #[pallet::weight(50_000)]
| ^^^^^^
|
|
use of deprecated constant `pallet::warnings::ImplicitCallIndex_1::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>:
frame/digital-twin/src/lib.rs#L84
warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_1::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>
--> frame/digital-twin/src/lib.rs:84:16
|
84 | pub fn set_source(
| ^^^^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ImplicitCallIndex_0::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>:
frame/digital-twin/src/lib.rs#L73
warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_0::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>
--> frame/digital-twin/src/lib.rs:73:16
|
73 | pub fn create(origin: OriginFor<T>) -> DispatchResultWithPostInfo {
| ^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_4::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/rws/src/lib.rs#L418
warning: use of deprecated constant `pallet::warnings::ConstantWeight_4::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/rws/src/lib.rs:418:26
|
418 | #[pallet::weight(100_000)]
| ^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_3::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/rws/src/lib.rs#L390
warning: use of deprecated constant `pallet::warnings::ConstantWeight_3::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/rws/src/lib.rs:390:26
|
390 | #[pallet::weight(100_000)]
| ^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_2::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/rws/src/lib.rs#L371
warning: use of deprecated constant `pallet::warnings::ConstantWeight_2::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/rws/src/lib.rs:371:26
|
371 | #[pallet::weight(100_000)]
| ^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/rws/src/lib.rs#L349
warning: use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/rws/src/lib.rs:349:26
|
349 | #[pallet::weight(100_000)]
| ^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/rws/src/lib.rs#L306
warning: use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/rws/src/lib.rs:306:26
|
306 | #[pallet::weight(100_000)]
| ^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ImplicitCallIndex_5::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>:
frame/rws/src/lib.rs#L419
warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_5::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>
--> frame/rws/src/lib.rs:419:16
|
419 | pub fn start_auction(
| ^^^^^^^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ImplicitCallIndex_4::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>:
frame/rws/src/lib.rs#L391
warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_4::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>
--> frame/rws/src/lib.rs:391:16
|
391 | pub fn set_subscription(
| ^^^^^^^^^^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ImplicitCallIndex_3::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>:
frame/rws/src/lib.rs#L372
warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_3::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>
--> frame/rws/src/lib.rs:372:16
|
372 | pub fn set_oracle(
| ^^^^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ImplicitCallIndex_2::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>:
frame/rws/src/lib.rs#L350
warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_2::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>
--> frame/rws/src/lib.rs:350:16
|
350 | pub fn set_devices(
| ^^^^^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ImplicitCallIndex_1::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>:
frame/rws/src/lib.rs#L307
warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_1::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>
--> frame/rws/src/lib.rs:307:16
|
307 | pub fn bid(
| ^^^
|
|
use of deprecated constant `pallet::warnings::ImplicitCallIndex_0::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>:
frame/rws/src/lib.rs#L275
warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_0::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>
--> frame/rws/src/lib.rs:275:16
|
275 | pub fn call(
| ^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
this let-binding has unit value:
frame/liability/src/lib.rs#L117
warning: this let-binding has unit value
--> frame/liability/src/lib.rs:117:26
|
117 | #[pallet::weight(200_000)]
| ^^^^^^^ help: omit the `let` binding: `200_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
= note: `#[warn(clippy::let_unit_value)]` on by default
|
|
binary comparison to literal `Option::None`:
frame/liability/src/lib.rs#L156
warning: binary comparison to literal `Option::None`
--> frame/liability/src/lib.rs:156:17
|
156 | <ReportOf<T>>::get(index) == None,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `<ReportOf<T>>::get(index).is_none()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
= note: `#[warn(clippy::partialeq_to_none)]` on by default
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/liability/src/lib.rs#L145
warning: use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/liability/src/lib.rs:145:26
|
145 | #[pallet::weight(200_000)]
| ^^^^^^^
|
|
this match could be written as a `let` statement:
frame/lighthouse/src/lib.rs#L215
warning: this match could be written as a `let` statement
--> frame/lighthouse/src/lib.rs:215:9
|
215 | / match InherentError::try_from(&INHERENT_IDENTIFIER, error)? {
216 | | o => Some(Err(sp_inherents::Error::Application(Box::from(o)))),
217 | | }
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding
= note: `#[warn(clippy::match_single_binding)]` on by default
help: consider using a `let` statement
|
215 ~ let o = InherentError::try_from(&INHERENT_IDENTIFIER, error)?;
216 + Some(Err(sp_inherents::Error::Application(Box::from(o))))
|
|
|
redundant field names in struct initialization:
frame/lighthouse/src/lib.rs#L128
warning: redundant field names in struct initialization
--> frame/lighthouse/src/lib.rs:128:17
|
128 | lighthouse: lighthouse,
| ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lighthouse`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
= note: `#[warn(clippy::redundant_field_names)]` on by default
|
|
the borrowed expression implements the required traits:
frame/datalog/src/lib.rs#L152
warning: the borrowed expression implements the required traits
--> frame/datalog/src/lib.rs:152:50
|
152 | let mut idx = DatalogIndex::<T>::get(&account);
| ^^^^^^^^ help: change this to: `account`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
|
this let-binding has unit value:
frame/launch/src/lib.rs#L58
warning: this let-binding has unit value
--> frame/launch/src/lib.rs:58:26
|
58 | #[pallet::weight(500_000)]
| ^^^^^^^ help: omit the `let` binding: `500_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
= note: `#[warn(clippy::let_unit_value)]` on by default
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/launch/src/lib.rs#L58
warning: use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/launch/src/lib.rs:58:26
|
58 | #[pallet::weight(500_000)]
| ^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|