-
Notifications
You must be signed in to change notification settings - Fork 60
{{ message }}
FIX: release action script #47
Annotations
65 warnings
|
large size difference between variants:
node/src/cli.rs#L73
warning: large size difference between variants
--> node/src/cli.rs:73:1
|
73 | / pub enum Subcommand {
74 | | /// Key management cli utilities
75 | | #[clap(subcommand)]
76 | | Key(sc_cli::KeySubcommand),
| | -------------------------- the second-largest variant contains at least 240 bytes
... |
116 | | Benchmark(frame_benchmarking_cli::BenchmarkCmd),
| | ----------------------------------------------- the largest variant contains at least 568 bytes
117 | | }
| |_^ the entire enum is at least 568 bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
= note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
|
116 | Benchmark(Box<frame_benchmarking_cli::BenchmarkCmd>),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
unneeded `return` statement:
node/src/chain_spec/mod.rs#L47
warning: unneeded `return` statement
--> node/src/chain_spec/mod.rs:47:9
|
47 | return RobonomicsFamily::Mainnet;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
47 - return RobonomicsFamily::Mainnet;
47 + RobonomicsFamily::Mainnet
|
|
|
function `genesis` is never used:
node/src/chain_spec/dev.rs#L78
warning: function `genesis` is never used
--> node/src/chain_spec/dev.rs:78:8
|
78 | pub fn genesis(
| ^^^^^^^
|
|
function `devnet_genesis` is never used:
node/src/chain_spec/dev.rs#L42
warning: function `devnet_genesis` is never used
--> node/src/chain_spec/dev.rs:42:4
|
42 | fn devnet_genesis(
| ^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
unneeded `return` statement:
runtime/dev/src/lib.rs#L854
warning: unneeded `return` statement
--> runtime/dev/src/lib.rs:854:13
|
854 | return (list, storage_info)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
854 | (list, storage_info)
|
|
|
this operation has no effect:
runtime/dev/src/lib.rs#L572
warning: this operation has no effect
--> runtime/dev/src/lib.rs:572:37
|
572 | pub const MinimalBid: Balance = 1 * XRT;
| ^^^^^^^ help: consider reducing it to: `XRT`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
|
|
this operation has no effect:
runtime/dev/src/lib.rs#L415
warning: this operation has no effect
--> runtime/dev/src/lib.rs:415:45
|
415 | pub const DataDepositPerByte: Balance = 1 * COASE;
| ^^^^^^^^^ help: consider reducing it to: `COASE`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
|
|
this operation has no effect:
runtime/dev/src/lib.rs#L396
warning: this operation has no effect
--> runtime/dev/src/lib.rs:396:46
|
396 | pub const PreimageBaseDeposit: Balance = 1 * XRT;
| ^^^^^^^ help: consider reducing it to: `XRT`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
|
|
this operation has no effect:
runtime/dev/src/lib.rs#L256
warning: this operation has no effect
--> runtime/dev/src/lib.rs:256:44
|
256 | pub const MinVestedTransfer: Balance = 1 * XRT;
| ^^^^^^^ help: consider reducing it to: `XRT`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
|
|
this operation has no effect:
runtime/dev/src/lib.rs#L202
warning: this operation has no effect
--> runtime/dev/src/lib.rs:202:45
|
202 | pub const ExistentialDeposit: Balance = 1 * COASE;
| ^^^^^^^^^ help: consider reducing it to: `COASE`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
= note: `#[warn(clippy::identity_op)]` on by default
|
|
this function has too many arguments (9/7):
node/service/src/parachain.rs#L296
warning: this function has too many arguments (9/7)
--> node/service/src/parachain.rs:296:1
|
296 | #[sc_tracing::logging::prefix_logs_with("Parachain")]
| ^----------------------------------------------------
| |
| _in this procedural macro expansion
| |
297 | | pub async fn new_service<RuntimeApi, RB, BIQ, BIC>(
298 | | parachain_config: Configuration,
299 | | polkadot_config: Configuration,
... |
332 | | bool,
333 | | ) -> Result<Box<dyn ParachainConsensus<Block>>, sc_service::Error>,
| |_______________________________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: this warning originates in the attribute macro `sc_tracing::logging::prefix_logs_with` (in Nightly builds, run with -Z macro-backtrace for more info)
|
|
very complex type used. Consider factoring parts into `type` definitions:
node/service/src/parachain.rs#L198
warning: very complex type used. Consider factoring parts into `type` definitions
--> node/service/src/parachain.rs:198:6
|
198 | ) -> Result<
| ______^
199 | | PartialComponents<
200 | | ParachainClient<RuntimeApi>,
201 | | ParachainBackend,
... |
211 | | sc_service::Error,
212 | | >
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
|
using `clone` on type `Role` which implements the `Copy` trait:
node/service/src/dev.rs#L329
warning: using `clone` on type `Role` which implements the `Copy` trait
--> node/service/src/dev.rs:329:16
|
329 | let role = config.role.clone();
| ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.role`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
|
very complex type used. Consider factoring parts into `type` definitions:
node/service/src/dev.rs#L231
warning: very complex type used. Consider factoring parts into `type` definitions
--> node/service/src/dev.rs:231:6
|
231 | ) -> Result<
| ______^
232 | | (
233 | | TaskManager,
234 | | Arc<FullClient<Runtime>>,
... |
238 | | ServiceError,
239 | | >
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
|
use of deprecated function `cumulus_client_service::start_collator`: use start_relay_chain_tasks instead:
node/service/src/parachain.rs#L474
warning: use of deprecated function `cumulus_client_service::start_collator`: use start_relay_chain_tasks instead
--> node/service/src/parachain.rs:474:9
|
474 | start_collator(params).await?;
| ^^^^^^^^^^^^^^
|
|
use of deprecated function `cumulus_client_service::start_full_node`: use start_relay_chain_tasks instead:
node/service/src/parachain.rs#L30
warning: use of deprecated function `cumulus_client_service::start_full_node`: use start_relay_chain_tasks instead
--> node/service/src/parachain.rs:30:5
|
30 | start_full_node, BuildNetworkParams, CollatorSybilResistance, StartCollatorParams,
| ^^^^^^^^^^^^^^^
|
|
use of deprecated function `cumulus_client_service::start_collator`: use start_relay_chain_tasks instead:
node/service/src/parachain.rs#L29
warning: use of deprecated function `cumulus_client_service::start_collator`: use start_relay_chain_tasks instead
--> node/service/src/parachain.rs:29:70
|
29 | build_network, build_relay_chain_interface, prepare_node_config, start_collator,
| ^^^^^^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
this let-binding has unit value:
frame/liability/src/lib.rs#L145
warning: this let-binding has unit value
--> frame/liability/src/lib.rs:145:26
|
145 | #[pallet::weight(200_000)]
| ^^^^^^^ help: omit the `let` binding: `200_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/liability/src/lib.rs#L117
warning: this let-binding has unit value
--> frame/liability/src/lib.rs:117:26
|
117 | #[pallet::weight(200_000)]
| ^^^^^^^ help: omit the `let` binding: `200_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
= note: `#[warn(clippy::let_unit_value)]` on by default
|
|
binary comparison to literal `Option::None`:
frame/liability/src/lib.rs#L156
warning: binary comparison to literal `Option::None`
--> frame/liability/src/lib.rs:156:17
|
156 | <ReportOf<T>>::get(index) == None,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `<ReportOf<T>>::get(index).is_none()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
= note: `#[warn(clippy::partialeq_to_none)]` on by default
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/liability/src/lib.rs#L145
warning: use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/liability/src/lib.rs:145:26
|
145 | #[pallet::weight(200_000)]
| ^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/liability/src/lib.rs#L117
warning: use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/liability/src/lib.rs:117:26
|
117 | #[pallet::weight(200_000)]
| ^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
this `else { if .. }` block can be collapsed:
frame/liability/src/signed.rs#L76
warning: this `else { if .. }` block can be collapsed
--> frame/liability/src/signed.rs:76:16
|
76 | } else {
| ________________^
77 | | if C::unreserve(&self.promisee, self.economics.price) == self.economics.price {
78 | | Ok(())
79 | | } else {
80 | | Err("reserved less than expected")?
81 | | }
82 | | }
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if
= note: `#[warn(clippy::collapsible_else_if)]` on by default
help: collapse nested if block
|
76 ~ } else if C::unreserve(&self.promisee, self.economics.price) == self.economics.price {
77 + Ok(())
78 + } else {
79 + Err("reserved less than expected")?
80 + }
|
|
|
this let-binding has unit value:
frame/digital-twin/src/lib.rs#L83
warning: this let-binding has unit value
--> frame/digital-twin/src/lib.rs:83:26
|
83 | #[pallet::weight(50_000)]
| ^^^^^^ help: omit the `let` binding: `50_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/digital-twin/src/lib.rs#L72
warning: this let-binding has unit value
--> frame/digital-twin/src/lib.rs:72:26
|
72 | #[pallet::weight(50_000)]
| ^^^^^^ help: omit the `let` binding: `50_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/digital-twin/src/lib.rs#L84
warning: this let-binding has unit value
--> frame/digital-twin/src/lib.rs:84:16
|
84 | pub fn set_source(
| ^^^^^^^^^^ help: omit the `let` binding: `set_source;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/digital-twin/src/lib.rs#L73
warning: this let-binding has unit value
--> frame/digital-twin/src/lib.rs:73:16
|
73 | pub fn create(origin: OriginFor<T>) -> DispatchResultWithPostInfo {
| ^^^^^^ help: omit the `let` binding: `create;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
= note: `#[warn(clippy::let_unit_value)]` on by default
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/digital-twin/src/lib.rs#L83
warning: use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/digital-twin/src/lib.rs:83:26
|
83 | #[pallet::weight(50_000)]
| ^^^^^^
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/digital-twin/src/lib.rs#L72
warning: use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/digital-twin/src/lib.rs:72:26
|
72 | #[pallet::weight(50_000)]
| ^^^^^^
|
|
use of deprecated constant `pallet::warnings::ImplicitCallIndex_1::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>:
frame/digital-twin/src/lib.rs#L84
warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_1::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>
--> frame/digital-twin/src/lib.rs:84:16
|
84 | pub fn set_source(
| ^^^^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ImplicitCallIndex_0::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>:
frame/digital-twin/src/lib.rs#L73
warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_0::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>
--> frame/digital-twin/src/lib.rs:73:16
|
73 | pub fn create(origin: OriginFor<T>) -> DispatchResultWithPostInfo {
| ^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L390
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:390:26
|
390 | #[pallet::weight(100_000)]
| ^^^^^^^ help: omit the `let` binding: `100_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L371
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:371:26
|
371 | #[pallet::weight(100_000)]
| ^^^^^^^ help: omit the `let` binding: `100_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L349
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:349:26
|
349 | #[pallet::weight(100_000)]
| ^^^^^^^ help: omit the `let` binding: `100_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L306
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:306:26
|
306 | #[pallet::weight(100_000)]
| ^^^^^^^ help: omit the `let` binding: `100_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L419
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:419:16
|
419 | pub fn start_auction(
| ^^^^^^^^^^^^^ help: omit the `let` binding: `start_auction;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L391
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:391:16
|
391 | pub fn set_subscription(
| ^^^^^^^^^^^^^^^^ help: omit the `let` binding: `set_subscription;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L372
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:372:16
|
372 | pub fn set_oracle(
| ^^^^^^^^^^ help: omit the `let` binding: `set_oracle;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L350
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:350:16
|
350 | pub fn set_devices(
| ^^^^^^^^^^^ help: omit the `let` binding: `set_devices;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L307
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:307:16
|
307 | pub fn bid(
| ^^^ help: omit the `let` binding: `bid;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L275
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:275:16
|
275 | pub fn call(
| ^^^^ help: omit the `let` binding: `call;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
frame/rws/src/lib.rs#L471
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> frame/rws/src/lib.rs:471:60
|
471 | T::AuctionCurrency::slash_reserved(&subscription_id, auction.best_price);
| ^^^^^^^^^^^^^^^^ help: change this to: `subscription_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
redundant pattern matching, consider using `is_ok()`:
frame/rws/src/lib.rs#L437
warning: redundant pattern matching, consider using `is_ok()`
--> frame/rws/src/lib.rs:437:20
|
437 | if let Ok(_) = <AuctionQueue<T>>::mutate(|queue| queue.try_push(index.clone())) {
| -------^^^^^------------------------------------------------------------------- help: try: `if <AuctionQueue<T>>::mutate(|queue| queue.try_push(index.clone())).is_ok()`
|
= note: this will change drop order of the result, as well as all temporaries
= note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
= note: `#[warn(clippy::redundant_pattern_matching)]` on by default
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L423
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:423:13
|
423 | let _ = ensure_root(origin)?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `ensure_root(origin)?;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
= note: `#[warn(clippy::let_unit_value)]` on by default
|
|
using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait:
frame/rws/src/lib.rs#L334
warning: using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait
--> frame/rws/src/lib.rs:334:38
|
334 | auction.best_price = amount.clone();
| ^^^^^^^^^^^^^^ help: try removing the `clone` call: `amount`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
|
using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait:
frame/rws/src/lib.rs#L332
warning: using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait
--> frame/rws/src/lib.rs:332:54
|
332 | T::AuctionCurrency::reserve(&sender, amount.clone())?;
| ^^^^^^^^^^^^^^ help: try removing the `clone` call: `amount`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
|
using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait:
frame/rws/src/lib.rs#L328
warning: using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait
--> frame/rws/src/lib.rs:328:38
|
328 | auction.best_price = amount.clone();
| ^^^^^^^^^^^^^^ help: try removing the `clone` call: `amount`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
frame/rws/src/lib.rs#L326
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> frame/rws/src/lib.rs:326:47
|
326 | T::AuctionCurrency::unreserve(&winner, auction.best_price);
| ^^^^^^^ help: change this to: `winner`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait:
frame/rws/src/lib.rs#L325
warning: using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait
--> frame/rws/src/lib.rs:325:54
|
325 | T::AuctionCurrency::reserve(&sender, amount.clone())?;
| ^^^^^^^^^^^^^^ help: try removing the `clone` call: `amount`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_4::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/rws/src/lib.rs#L418
warning: use of deprecated constant `pallet::warnings::ConstantWeight_4::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/rws/src/lib.rs:418:26
|
418 | #[pallet::weight(100_000)]
| ^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_3::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/rws/src/lib.rs#L390
warning: use of deprecated constant `pallet::warnings::ConstantWeight_3::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/rws/src/lib.rs:390:26
|
390 | #[pallet::weight(100_000)]
| ^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_2::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/rws/src/lib.rs#L371
warning: use of deprecated constant `pallet::warnings::ConstantWeight_2::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/rws/src/lib.rs:371:26
|
371 | #[pallet::weight(100_000)]
| ^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/rws/src/lib.rs#L349
warning: use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/rws/src/lib.rs:349:26
|
349 | #[pallet::weight(100_000)]
| ^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/rws/src/lib.rs#L306
warning: use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/rws/src/lib.rs:306:26
|
306 | #[pallet::weight(100_000)]
| ^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ImplicitCallIndex_5::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>:
frame/rws/src/lib.rs#L419
warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_5::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>
--> frame/rws/src/lib.rs:419:16
|
419 | pub fn start_auction(
| ^^^^^^^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ImplicitCallIndex_4::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>:
frame/rws/src/lib.rs#L391
warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_4::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>
--> frame/rws/src/lib.rs:391:16
|
391 | pub fn set_subscription(
| ^^^^^^^^^^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ImplicitCallIndex_3::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>:
frame/rws/src/lib.rs#L372
warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_3::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>
--> frame/rws/src/lib.rs:372:16
|
372 | pub fn set_oracle(
| ^^^^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ImplicitCallIndex_2::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>:
frame/rws/src/lib.rs#L350
warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_2::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>
--> frame/rws/src/lib.rs:350:16
|
350 | pub fn set_devices(
| ^^^^^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ImplicitCallIndex_1::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>:
frame/rws/src/lib.rs#L307
warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_1::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>
--> frame/rws/src/lib.rs:307:16
|
307 | pub fn bid(
| ^^^
|
|
use of deprecated constant `pallet::warnings::ImplicitCallIndex_0::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>:
frame/rws/src/lib.rs#L275
warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_0::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>
--> frame/rws/src/lib.rs:275:16
|
275 | pub fn call(
| ^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
this match could be written as a `let` statement:
frame/lighthouse/src/lib.rs#L215
warning: this match could be written as a `let` statement
--> frame/lighthouse/src/lib.rs:215:9
|
215 | / match InherentError::try_from(&INHERENT_IDENTIFIER, error)? {
216 | | o => Some(Err(sp_inherents::Error::Application(Box::from(o)))),
217 | | }
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding
= note: `#[warn(clippy::match_single_binding)]` on by default
help: consider using a `let` statement
|
215 ~ let o = InherentError::try_from(&INHERENT_IDENTIFIER, error)?;
216 + Some(Err(sp_inherents::Error::Application(Box::from(o))))
|
|
|
redundant field names in struct initialization:
frame/lighthouse/src/lib.rs#L128
warning: redundant field names in struct initialization
--> frame/lighthouse/src/lib.rs:128:17
|
128 | lighthouse: lighthouse,
| ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lighthouse`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
= note: `#[warn(clippy::redundant_field_names)]` on by default
|
|
this let-binding has unit value:
frame/launch/src/lib.rs#L58
warning: this let-binding has unit value
--> frame/launch/src/lib.rs:58:26
|
58 | #[pallet::weight(500_000)]
| ^^^^^^^ help: omit the `let` binding: `500_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
= note: `#[warn(clippy::let_unit_value)]` on by default
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/launch/src/lib.rs#L58
warning: use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/launch/src/lib.rs:58:26
|
58 | #[pallet::weight(500_000)]
| ^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
the borrowed expression implements the required traits:
frame/datalog/src/lib.rs#L152
warning: the borrowed expression implements the required traits
--> frame/datalog/src/lib.rs:152:50
|
152 | let mut idx = DatalogIndex::<T>::get(&account);
| ^^^^^^^^ help: change this to: `account`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|