Optimized RWS storage, removed devices functions (use proxy instead) #51
base_checks.yaml
on: push
compile-and-check
22m 28s
Annotations
62 warnings
|
large size difference between variants:
node/src/cli.rs#L73
warning: large size difference between variants
--> node/src/cli.rs:73:1
|
73 | / pub enum Subcommand {
74 | | /// Key management cli utilities
75 | | #[clap(subcommand)]
76 | | Key(sc_cli::KeySubcommand),
| | -------------------------- the second-largest variant contains at least 240 bytes
... |
116 | | Benchmark(frame_benchmarking_cli::BenchmarkCmd),
| | ----------------------------------------------- the largest variant contains at least 592 bytes
117 | | }
| |_^ the entire enum is at least 592 bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
= note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
|
116 | Benchmark(Box<frame_benchmarking_cli::BenchmarkCmd>),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
unneeded `return` statement:
node/src/chain_spec/mod.rs#L47
warning: unneeded `return` statement
--> node/src/chain_spec/mod.rs:47:9
|
47 | return RobonomicsFamily::Mainnet;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
47 - return RobonomicsFamily::Mainnet;
47 + RobonomicsFamily::Mainnet
|
|
|
function `genesis` is never used:
node/src/chain_spec/dev.rs#L78
warning: function `genesis` is never used
--> node/src/chain_spec/dev.rs:78:8
|
78 | pub fn genesis(
| ^^^^^^^
|
|
function `devnet_genesis` is never used:
node/src/chain_spec/dev.rs#L42
warning: function `devnet_genesis` is never used
--> node/src/chain_spec/dev.rs:42:4
|
42 | fn devnet_genesis(
| ^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
unneeded `return` statement:
runtime/dev/src/lib.rs#L859
warning: unneeded `return` statement
--> runtime/dev/src/lib.rs:859:13
|
859 | return (list, storage_info)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
859 | (list, storage_info)
|
|
|
this operation has no effect:
runtime/dev/src/lib.rs#L582
warning: this operation has no effect
--> runtime/dev/src/lib.rs:582:37
|
582 | pub const MinimalBid: Balance = 1 * XRT;
| ^^^^^^^ help: consider reducing it to: `XRT`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
|
|
this operation has no effect:
runtime/dev/src/lib.rs#L423
warning: this operation has no effect
--> runtime/dev/src/lib.rs:423:45
|
423 | pub const DataDepositPerByte: Balance = 1 * COASE;
| ^^^^^^^^^ help: consider reducing it to: `COASE`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
|
|
this operation has no effect:
runtime/dev/src/lib.rs#L404
warning: this operation has no effect
--> runtime/dev/src/lib.rs:404:46
|
404 | pub const PreimageBaseDeposit: Balance = 1 * XRT;
| ^^^^^^^ help: consider reducing it to: `XRT`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
|
|
this operation has no effect:
runtime/dev/src/lib.rs#L260
warning: this operation has no effect
--> runtime/dev/src/lib.rs:260:44
|
260 | pub const MinVestedTransfer: Balance = 1 * XRT;
| ^^^^^^^ help: consider reducing it to: `XRT`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
|
|
this operation has no effect:
runtime/dev/src/lib.rs#L203
warning: this operation has no effect
--> runtime/dev/src/lib.rs:203:45
|
203 | pub const ExistentialDeposit: Balance = 1 * COASE;
| ^^^^^^^^^ help: consider reducing it to: `COASE`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
= note: `#[warn(clippy::identity_op)]` on by default
|
|
use of deprecated type alias `sp_runtime::RuntimeString`: Use String or Cow<'static, str> instead:
runtime/dev/src/lib.rs#L864
warning: use of deprecated type alias `sp_runtime::RuntimeString`: Use String or Cow<'static, str> instead
--> runtime/dev/src/lib.rs:864:74
|
864 | ) -> Result<Vec<frame_benchmarking::BenchmarkBatch>, sp_runtime::RuntimeString> {
| ^^^^^^^^^^^^^
|
|
use of deprecated macro `sp_runtime::create_runtime_str`: Use Cow::Borrowed() instead of create_runtime_str!():
runtime/dev/src/lib.rs#L70
warning: use of deprecated macro `sp_runtime::create_runtime_str`: Use Cow::Borrowed() instead of create_runtime_str!()
--> runtime/dev/src/lib.rs:70:5
|
70 | create_runtime_str, generic, impl_opaque_keys,
| ^^^^^^^^^^^^^^^^^^
|
|
use of deprecated macro `create_runtime_str`: Use Cow::Borrowed() instead of create_runtime_str!():
runtime/dev/src/lib.rs#L94
warning: use of deprecated macro `create_runtime_str`: Use Cow::Borrowed() instead of create_runtime_str!()
--> runtime/dev/src/lib.rs:94:16
|
94 | impl_name: create_runtime_str!("robonomics-dev-airalab"),
| ^^^^^^^^^^^^^^^^^^
|
|
use of deprecated macro `create_runtime_str`: Use Cow::Borrowed() instead of create_runtime_str!():
runtime/dev/src/lib.rs#L93
warning: use of deprecated macro `create_runtime_str`: Use Cow::Borrowed() instead of create_runtime_str!()
--> runtime/dev/src/lib.rs:93:16
|
93 | spec_name: create_runtime_str!("robonomics-dev"),
| ^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
this function has too many arguments (9/7):
node/service/src/parachain.rs#L301
warning: this function has too many arguments (9/7)
--> node/service/src/parachain.rs:301:1
|
301 | #[sc_tracing::logging::prefix_logs_with("Parachain")]
| ^----------------------------------------------------
| |
| _in this procedural macro expansion
| |
302 | | pub async fn new_service<RuntimeApi, RB, BIQ, BIC>(
303 | | parachain_config: Configuration,
304 | | polkadot_config: Configuration,
... |
337 | | bool,
338 | | ) -> Result<Box<dyn ParachainConsensus<Block>>, sc_service::Error>,
| |_______________________________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: this warning originates in the attribute macro `sc_tracing::logging::prefix_logs_with` (in Nightly builds, run with -Z macro-backtrace for more info)
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
node/service/src/parachain.rs#L254
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> node/service/src/parachain.rs:254:13
|
254 | &config,
| ^^^^^^^ help: change this to: `config`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
very complex type used. Consider factoring parts into `type` definitions:
node/service/src/parachain.rs#L200
warning: very complex type used. Consider factoring parts into `type` definitions
--> node/service/src/parachain.rs:200:6
|
200 | ) -> Result<
| ______^
201 | | PartialComponents<
202 | | ParachainClient<RuntimeApi>,
203 | | ParachainBackend,
... |
213 | | sc_service::Error,
214 | | >
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
|
this function has too many arguments (12/7):
node/service/src/parachain.rs#L121
warning: this function has too many arguments (12/7)
--> node/service/src/parachain.rs:121:1
|
121 | / pub fn build_open_consensus<RuntimeApi>(
122 | | para_id: ParaId,
123 | | lighthouse_account: AccountId,
124 | | client: Arc<ParachainClient<RuntimeApi>>,
... |
135 | | _force_authoring: bool,
136 | | ) -> Result<Box<dyn ParachainConsensus<Block>>, sc_service::Error>
| |__________________________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
|
|
using `clone` on type `Option<&Registry>` which implements the `Copy` trait:
node/service/src/parachain.rs#L115
warning: using `clone` on type `Option<&Registry>` which implements the `Copy` trait
--> node/service/src/parachain.rs:115:9
|
115 | registry.clone(),
| ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `registry`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
|
using `clone` on type `Role` which implements the `Copy` trait:
node/service/src/dev.rs#L333
warning: using `clone` on type `Role` which implements the `Copy` trait
--> node/service/src/dev.rs:333:16
|
333 | let role = config.role.clone();
| ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.role`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
|
very complex type used. Consider factoring parts into `type` definitions:
node/service/src/dev.rs#L233
warning: very complex type used. Consider factoring parts into `type` definitions
--> node/service/src/dev.rs:233:6
|
233 | ) -> Result<
| ______^
234 | | (
235 | | TaskManager,
236 | | Arc<FullClient<Runtime>>,
... |
240 | | ServiceError,
241 | | >
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
node/service/src/dev.rs#L138
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> node/service/src/dev.rs:138:13
|
138 | &config,
| ^^^^^^^ help: change this to: `config`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
very complex type used. Consider factoring parts into `type` definitions:
node/service/src/dev.rs#L88
warning: very complex type used. Consider factoring parts into `type` definitions
--> node/service/src/dev.rs:88:6
|
88 | ) -> Result<
| ______^
89 | | sc_service::PartialComponents<
90 | | FullClient<Runtime>,
91 | | FullBackend,
... |
104 | | ServiceError,
105 | | >
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
|
unused variable: `warp_sync`:
node/service/src/dev.rs#L290
warning: unused variable: `warp_sync`
--> node/service/src/dev.rs:290:9
|
290 | let warp_sync = Arc::new(sc_consensus_grandpa::warp_proof::NetworkProvider::new(
| ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_warp_sync`
|
= note: `#[warn(unused_variables)]` on by default
|
|
use of deprecated function `cumulus_client_service::start_full_node`: use start_relay_chain_tasks instead:
node/service/src/parachain.rs#L493
warning: use of deprecated function `cumulus_client_service::start_full_node`: use start_relay_chain_tasks instead
--> node/service/src/parachain.rs:493:9
|
493 | start_full_node(params)?;
| ^^^^^^^^^^^^^^^
|
|
use of deprecated function `cumulus_client_service::start_collator`: use start_relay_chain_tasks instead:
node/service/src/parachain.rs#L479
warning: use of deprecated function `cumulus_client_service::start_collator`: use start_relay_chain_tasks instead
--> node/service/src/parachain.rs:479:9
|
479 | start_collator(params).await?;
| ^^^^^^^^^^^^^^
|
|
use of deprecated function `cumulus_client_service::start_full_node`: use start_relay_chain_tasks instead:
node/service/src/parachain.rs#L30
warning: use of deprecated function `cumulus_client_service::start_full_node`: use start_relay_chain_tasks instead
--> node/service/src/parachain.rs:30:5
|
30 | start_full_node, BuildNetworkParams, CollatorSybilResistance, StartCollatorParams,
| ^^^^^^^^^^^^^^^
|
|
use of deprecated function `cumulus_client_service::start_collator`: use start_relay_chain_tasks instead:
node/service/src/parachain.rs#L29
warning: use of deprecated function `cumulus_client_service::start_collator`: use start_relay_chain_tasks instead
--> node/service/src/parachain.rs:29:70
|
29 | build_network, build_relay_chain_interface, prepare_node_config, start_collator,
| ^^^^^^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
this let-binding has unit value:
frame/liability/src/lib.rs#L145
warning: this let-binding has unit value
--> frame/liability/src/lib.rs:145:26
|
145 | #[pallet::weight(200_000)]
| ^^^^^^^ help: omit the `let` binding: `200_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/liability/src/lib.rs#L117
warning: this let-binding has unit value
--> frame/liability/src/lib.rs:117:26
|
117 | #[pallet::weight(200_000)]
| ^^^^^^^ help: omit the `let` binding: `200_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
= note: `#[warn(clippy::let_unit_value)]` on by default
|
|
binary comparison to literal `Option::None`:
frame/liability/src/lib.rs#L156
warning: binary comparison to literal `Option::None`
--> frame/liability/src/lib.rs:156:17
|
156 | <ReportOf<T>>::get(index) == None,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `<ReportOf<T>>::get(index).is_none()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
= note: `#[warn(clippy::partialeq_to_none)]` on by default
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/liability/src/lib.rs#L145
warning: use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/liability/src/lib.rs:145:26
|
145 | #[pallet::weight(200_000)]
| ^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/liability/src/lib.rs#L117
warning: use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/liability/src/lib.rs:117:26
|
117 | #[pallet::weight(200_000)]
| ^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
this `else { if .. }` block can be collapsed:
frame/liability/src/signed.rs#L76
warning: this `else { if .. }` block can be collapsed
--> frame/liability/src/signed.rs:76:16
|
76 | } else {
| ________________^
77 | | if C::unreserve(&self.promisee, self.economics.price) == self.economics.price {
78 | | Ok(())
79 | | } else {
80 | | Err("reserved less than expected")?
81 | | }
82 | | }
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if
= note: `#[warn(clippy::collapsible_else_if)]` on by default
help: collapse nested if block
|
76 ~ } else if C::unreserve(&self.promisee, self.economics.price) == self.economics.price {
77 + Ok(())
78 + } else {
79 + Err("reserved less than expected")?
80 + }
|
|
|
very complex type used. Consider factoring parts into `type` definitions:
frame/rws/src/lib.rs#L208
warning: very complex type used. Consider factoring parts into `type` definitions
--> frame/rws/src/lib.rs:208:15
|
208 | #[pallet::storage]
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
|
this let-binding has unit value:
frame/rws/src/lib.rs#L408
warning: this let-binding has unit value
--> frame/rws/src/lib.rs:408:13
|
408 | let _ = ensure_root(origin)?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `ensure_root(origin)?;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
= note: `#[warn(clippy::let_unit_value)]` on by default
|
|
the borrowed expression implements the required traits:
frame/rws/src/lib.rs#L387
warning: the borrowed expression implements the required traits
--> frame/rws/src/lib.rs:387:31
|
387 | <Auction<T>>::set(&auction_id, Some(auction));
| ^^^^^^^^^^^ help: change this to: `auction_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
frame/rws/src/lib.rs#L381
warning: the borrowed expression implements the required traits
--> frame/rws/src/lib.rs:381:17
|
381 | &subscription_id,
| ^^^^^^^^^^^^^^^^ help: change this to: `subscription_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
binary comparison to literal `Option::None`:
frame/rws/src/lib.rs#L355
warning: binary comparison to literal `Option::None`
--> frame/rws/src/lib.rs:355:17
|
355 | auction.subscription_id == None,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `auction.subscription_id.is_none()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
= note: `#[warn(clippy::partialeq_to_none)]` on by default
|
|
the borrowed expression implements the required traits:
frame/rws/src/lib.rs#L351
warning: the borrowed expression implements the required traits
--> frame/rws/src/lib.rs:351:49
|
351 | let mut auction = <Auction<T>>::get(&auction_id).ok_or(Error::<T>::NotExistAuction)?;
| ^^^^^^^^^^^ help: change this to: `auction_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
frame/rws/src/lib.rs#L328
warning: the borrowed expression implements the required traits
--> frame/rws/src/lib.rs:328:31
|
328 | <Auction<T>>::set(&auction_id, Some(auction));
| ^^^^^^^^^^^ help: change this to: `auction_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait:
frame/rws/src/lib.rs#L326
warning: using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait
--> frame/rws/src/lib.rs:326:38
|
326 | auction.best_price = amount.clone();
| ^^^^^^^^^^^^^^ help: try removing the `clone` call: `amount`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
|
using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait:
frame/rws/src/lib.rs#L324
warning: using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait
--> frame/rws/src/lib.rs:324:54
|
324 | T::AuctionCurrency::reserve(&sender, amount.clone())?;
| ^^^^^^^^^^^^^^ help: try removing the `clone` call: `amount`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
|
using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait:
frame/rws/src/lib.rs#L318
warning: using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait
--> frame/rws/src/lib.rs:318:38
|
318 | auction.best_price = amount.clone();
| ^^^^^^^^^^^^^^ help: try removing the `clone` call: `amount`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
frame/rws/src/lib.rs#L316
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> frame/rws/src/lib.rs:316:47
|
316 | T::AuctionCurrency::unreserve(&winner, auction.best_price);
| ^^^^^^^ help: change this to: `winner`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait:
frame/rws/src/lib.rs#L315
warning: using `clone` on type `<<T as Config>::AuctionCurrency as Currency<<T as Config>::AccountId>>::Balance` which implements the `Copy` trait
--> frame/rws/src/lib.rs:315:54
|
315 | T::AuctionCurrency::reserve(&sender, amount.clone())?;
| ^^^^^^^^^^^^^^ help: try removing the `clone` call: `amount`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
|
the borrowed expression implements the required traits:
frame/rws/src/lib.rs#L304
warning: the borrowed expression implements the required traits
--> frame/rws/src/lib.rs:304:49
|
304 | let mut auction = <Auction<T>>::get(&auction_id).ok_or(Error::<T>::NotExistAuction)?;
| ^^^^^^^^^^^ help: change this to: `auction_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
frame/rws/src/lib.rs#L273
warning: the borrowed expression implements the required traits
--> frame/rws/src/lib.rs:273:49
|
273 | <Subscription<T>>::set(&sender, &subscription_id, Some(subscription));
| ^^^^^^^^^^^^^^^^ help: change this to: `subscription_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
frame/rws/src/lib.rs#L269
warning: the borrowed expression implements the required traits
--> frame/rws/src/lib.rs:269:49
|
269 | <Subscription<T>>::set(&sender, &subscription_id, Some(subscription));
| ^^^^^^^^^^^^^^^^ help: change this to: `subscription_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
frame/rws/src/lib.rs#L243
warning: the borrowed expression implements the required traits
--> frame/rws/src/lib.rs:243:68
|
243 | let mut subscription = <Subscription<T>>::get(&sender, &subscription_id)
| ^^^^^^^^^^^^^^^^ help: change this to: `subscription_id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
|
this let-binding has unit value:
frame/digital-twin/src/lib.rs#L83
warning: this let-binding has unit value
--> frame/digital-twin/src/lib.rs:83:26
|
83 | #[pallet::weight(50_000)]
| ^^^^^^ help: omit the `let` binding: `50_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/digital-twin/src/lib.rs#L72
warning: this let-binding has unit value
--> frame/digital-twin/src/lib.rs:72:26
|
72 | #[pallet::weight(50_000)]
| ^^^^^^ help: omit the `let` binding: `50_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this let-binding has unit value:
frame/digital-twin/src/lib.rs#L84
warning: this let-binding has unit value
--> frame/digital-twin/src/lib.rs:84:16
|
84 | pub fn set_source(
| ^^^^^^^^^^ help: omit the `let` binding: `set_source;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
|
|
this match could be written as a `let` statement:
frame/lighthouse/src/lib.rs#L215
warning: this match could be written as a `let` statement
--> frame/lighthouse/src/lib.rs:215:9
|
215 | / match InherentError::try_from(&INHERENT_IDENTIFIER, error)? {
216 | | o => Some(Err(sp_inherents::Error::Application(Box::from(o)))),
217 | | }
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding
= note: `#[warn(clippy::match_single_binding)]` on by default
help: consider using a `let` statement
|
215 ~ let o = InherentError::try_from(&INHERENT_IDENTIFIER, error)?;
216 + Some(Err(sp_inherents::Error::Application(Box::from(o))))
|
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/digital-twin/src/lib.rs#L83
warning: use of deprecated constant `pallet::warnings::ConstantWeight_1::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/digital-twin/src/lib.rs:83:26
|
83 | #[pallet::weight(50_000)]
| ^^^^^^
|
|
use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>:
frame/digital-twin/src/lib.rs#L72
warning: use of deprecated constant `pallet::warnings::ConstantWeight_0::_w`:
It is deprecated to use hard-coded constant as call weight.
Please instead benchmark all calls or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/13798>
--> frame/digital-twin/src/lib.rs:72:26
|
72 | #[pallet::weight(50_000)]
| ^^^^^^
|
|
use of deprecated constant `pallet::warnings::ImplicitCallIndex_1::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>:
frame/digital-twin/src/lib.rs#L84
warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_1::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>
--> frame/digital-twin/src/lib.rs:84:16
|
84 | pub fn set_source(
| ^^^^^^^^^^
|
|
use of deprecated constant `pallet::warnings::ImplicitCallIndex_0::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>:
frame/digital-twin/src/lib.rs#L73
warning: use of deprecated constant `pallet::warnings::ImplicitCallIndex_0::_w`:
It is deprecated to use implicit call indices.
Please instead ensure that all calls have a `pallet::call_index` attribute or put the pallet into `dev` mode.
For more info see:
<https://github.com/paritytech/substrate/pull/12891>
<https://github.com/paritytech/substrate/pull/11381>
--> frame/digital-twin/src/lib.rs:73:16
|
73 | pub fn create(origin: OriginFor<T>) -> DispatchResultWithPostInfo {
| ^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
this let-binding has unit value:
frame/launch/src/lib.rs#L58
warning: this let-binding has unit value
--> frame/launch/src/lib.rs:58:26
|
58 | #[pallet::weight(500_000)]
| ^^^^^^^ help: omit the `let` binding: `500_000;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
= note: `#[warn(clippy::let_unit_value)]` on by default
|
|
use of deprecated type alias `sp_runtime::RuntimeString`: Use String or Cow<'static, str> instead:
frame/lighthouse/src/lib.rs#L159
warning: use of deprecated type alias `sp_runtime::RuntimeString`: Use String or Cow<'static, str> instead
--> frame/lighthouse/src/lib.rs:159:23
|
159 | Other(sp_runtime::RuntimeString),
| ^^^^^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
redundant field names in struct initialization:
frame/lighthouse/src/lib.rs#L128
warning: redundant field names in struct initialization
--> frame/lighthouse/src/lib.rs:128:17
|
128 | lighthouse: lighthouse,
| ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lighthouse`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
= note: `#[warn(clippy::redundant_field_names)]` on by default
|
|
the borrowed expression implements the required traits:
frame/datalog/src/lib.rs#L152
warning: the borrowed expression implements the required traits
--> frame/datalog/src/lib.rs:152:50
|
152 | let mut idx = DatalogIndex::<T>::get(&account);
| ^^^^^^^^ help: change this to: `account`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|