8000 fix dependency self referencing issue by normanchia-imda · Pull Request #420 · aiverify-foundation/moonshot · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix dependency self referencing issue #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 20, 2025
Merged

fix dependency self referencing issue #420

merged 10 commits into from
May 20, 2025

Conversation

normanchia-imda
Copy link
Contributor

Description

fix the issue where the installation of dependency reference on itself.

Motivation and Context

[Explain the motivation or the context behind this pull request. Why is it necessary?]

Type of Change

How to Test

[Provide clear instructions on how to test and verify the changes introduced by this pull request, including any specific unit tests you have created to demonstrate your changes.]

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have added or updated the necessary documentation (README, API docs, etc.).
  • I have added appropriate unit tests or functional tests for the changes made.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have added any necessary dependencies or packages to the project's build configuration.
  • I have performed a self-review of my own code.
  • I have read, understood and agree to the Developer Certificate of Origin below, which this project utilises.

Screenshots (if applicable)

[If the changes involve visual modifications, include screenshots or GIFs that demonstrate the changes.]

Additional Notes

[Add any additional information or context that might be relevant to reviewers.]

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
   have the right to submit it under the open source license
   indicated in the file; or

(b) The contribution is based upon previous work that, to the best
   of my knowledge, is covered under an appropriate open source
   license and I have the right under that license to submit that
   work with modifications, whether created in whole or in part
   by me, under the same open source license (unless I am
   permitted to submit under a different license), as indicated
   in the file; or

(c) The contribution was provided directly to me by some other
   person who certified (a), (b) or (c) and I have not modified
   it.

(d) I understand and agree that this project and the contribution
   are public and that a record of the contribution (including all
   personal information I submit with it, including my sign-off) is
   maintained indefinitely and may be redistributed consistent with
   this project or the open source license(s) involved.

@imda-jacksonboey imda-jacksonboey changed the base branch from main to dev_main May 20, 2025 07:04
@imda-jacksonboey
Copy link
Contributor
Screenshot 2025-05-20 at 3 05 48 PM Screenshot 2025-05-20 at 3 06 23 PM

Smoke Test passed

@imda-jacksonboey imda-jacksonboey self-requested a review May 20, 2025 13:30
imda-jacksonboey
imda-jacksonboey approved these changes May 20, 2025
View reviewed changes
Copy link
Contributor
@imda-jacksonboey imda-jacksonboey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8000

Tested ok

@imda-jacksonboey imda-jacksonboey merged commit de74f75 into dev_main May 20, 2025
3 of 5 checks passed
@imda-jacksonboey imda-jacksonboey deleted the fix-dependency branch May 20, 2025 14:49
@imda-jacksonboey imda-jacksonboey mentioned this pull request May 21, 2025
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imda-lionelteo imda-lionelteo imda-lionelteo approved these changes

@imda-jacksonboey imda-jacksonboey imda-jacksonboey approved these changes

@imda-kelvinkok imda-kelvinkok Awaiting requested review from imda-kelvinkok

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@normanchia-imda @imda-jacksonboey @imda-lionelteo
0