ReadOnlyMemory<char> switched to String/ReadOnlySpan<char> #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches from
ReadOnlyMemory<char>toString/ReadOnlySpan<char>for FullText & Prefixindices. This is a breaking change.The motivation for the breaking change is simplicity and having an intuitive interface. And in hindsight, using
ReadOnlyMemory<char>can be considered premature optimization. Adding that almost all usages just pass in astringwith.AsMemory()anyway, it makes no sense in keeping that.How to update
.AsMemory(). Make sure to do that while building the sets as well as when querying. You can use this PR as a guideline.ReadOnlyMemory<char>you’ll need to convert it. For creating (and naming) an index, using a static method is recommended. For query parameters, you can just call.ToString()on it to obtain a string.