add response code validations for mcp request #2737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances MCP response handling by validating HTTP status codes and updates corresponding tests.
- Added a default 200 status code in the response helper method
- Refactored
testNullPayloadto verify URL propagation instead of expecting an exception - Cleaned up URL assignment in the test
Comments suppressed due to low confidence (2)
libs/utils/src/test/java/com/akto/mcp/McpRequestResponseUtilsTest.java:119
- Consider adding a test for non-2xx
statusCode(e.g., 404) to verify thatparseMcpResponseParamscorrectly throws an exception when the response code is outside the valid range.
Assertions.assertEquals(url, afterMcp.getRequestParams().getURL());
libs/utils/src/test/java/com/akto/mcp/McpRequestResponseUtilsTest.java:115
- The
responseParamsintestNullPayloadhas nostatusCodeset, so it may default to an invalid code. AddresponseParams.statusCode = 200;(or use the setter) before parsing to align with valid response scenarios.
HttpResponseParams responseParams = new HttpResponseParams();
| @@ -26,6 +26,7 @@ private HttpResponseParams createHttpResponseParams(String payload, String url) | |||
|
|
|||
| HttpResponseParams responseParams = new HttpResponseParams(); | |||
| responseParams.setRequestParams(reqParams); | |||
| responseParams.statusCode = 200; | |||
There was a problem hiding this comment.
[nitpick] Use the provided setter (e.g., responseParams.setStatusCode(200)) instead of directly accessing the statusCode field to maintain encapsulation and consistency.
Suggested change
| responseParams.statusCode = 200; | |
| responseParams.setStatusCode(200); |
Copilot uses AI. Check for mistakes.
notshivansh
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.