8000 tools: block-generator option to delay before running scenario. by winder · Pull Request #5694 · algorand/go-algorand · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

tools: block-generator option to delay before running scenario. #5694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

winder
Copy link
Contributor
@winder winder commented Aug 21, 2023

Summary

New block generator option to delay the start of a test. After noticing large variation in snapshot test performance results, we wonder if there could be some postgres processes from earlier tests effecting latter tests. This option gives us a simple way to test that by putting a delay between runs.

@winder winder requested review from a team, tzaffi, Eric-Warehime, shiqizng and algochoi and removed request for a team August 21, 2023 19:49
@winder winder self-assigned this Aug 21, 2023
@codecov
Copy link
codecov bot commented Aug 21, 2023

Codecov Report

Merging #5694 (d746d4c) into master (8281f8a) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5694      +/-   ##
==========================================
- Coverage   55.22%   55.21%   -0.02%     
==========================================
  Files         466      466              
  Lines       65084    65084              
==========================================
- Hits        35942    35934       -8     
- Misses      26759    26764       +5     
- Partials     2383     2386       +3     

see 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor
@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one question

@winder winder requested a review from tzaffi August 21, 2023 20:58
@winder winder marked this pull request as ready for review August 21, 2023 20:58
@winder winder merged commit bce4009 into algorand:master Aug 22, 2023
@winder winder deleted the will/bg-start-delay branch August 22, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0