fix(ui): prevent AddPoolModal closing during pool creation #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve handling of pool creation flow by pausing query refetches until the pool's box storage is initialized. Previously, the modal would close prematurely when queries attempted to fetch stakers data from the pool's box storage before the box was created in step 2. - Add `onClose` callback to `AddPoolModal` to communicate success/failure state - Pause staking data queries while pool creation is in progress - Move query invalidation to `StakingDetails` component - Add `refetchAll` function to `useStakersChartData` for coordinated refetching - Update empty state message in pie chart to be more descriptive - Consider pool creation successful after MBR payment (step 2) The `onClose` handler is optional as this fix is specific to adding pools from the `StakingDetails` component where stakers data is refetched every 30 seconds. Adding pools from the dashboard does not require this handling.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Move pool-related state and logic from `StakingDetails` to `ValidatorDetails` component to avoid duplicate `AddPoolModal` instances. Extract pool selection logic into `SelectPool` component. - Delete `StakingDetails` component and move its logic to `ValidatorDetails` - Extract pool selection logic into `SelectPool` component - Move `AddPoolModal` state and `canAddPool` logic to `ValidatorDetails` - Pass pool-related props from `ValidatorDetails` to `Highlights` - Add `StakerChartData` interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the add pool modal would close prematurely when queries attempted to fetch stakers data before the pool's box storage was initialized. The fix required refactoring state management to better coordinate query timing and modal lifecycle.
Details
ValidatorDetailsto avoid duplicate modalsSelectPoolcomponentrefetchAllfunctiononClosecallback toAddPoolModalto trigger staking data queries refetch