fix(ui): improve dialog accessibility and DOM nesting #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000
Replace `div` with `span` in `AlertDialogDescription` to prevent invalid DOM nesting of block-level elements inside paragraphs. `AlertDialogDescription` renders as a `p` element, which cannot contain `div` elements per HTML spec.
Add `DialogHeader` with title and description to loading state and improve error state titles for better accessibility and screen reader support.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses accessibility warnings in the
AddStakeModalcomponent and fixes invalid DOM nesting in the reward token dialog. These changes improve screen reader support and HTML validity.Details
DialogHeaderwith title and description to loading state inAddStakeModaldivwithspaninAlertDialogDescriptionto prevent invalid DOM nesting