Reduce Body size #1065
Merged
Reduce Body size #1065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1bb39c2 to
0c0f3c1
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR aims to reduce the overall Body size by updating various threshold values in the ensure! macro calls and modifying the BodyHandler usage to decrease the structure’s footprint.
- Updated ensure! macro thresholds for RequestBuilder, Response, and Body in src/lib.rs
- Introduced boxing for BodyHandler in src/body/mod.rs to reduce memory usage
- Updated CHANGELOG.md to reflect the change
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/lib.rs | Adjusted size thresholds for various types to lower body size |
| src/body/mod.rs | Wrapped BodyHandler in Box for more efficient memory usage |
| CHANGELOG.md | Added note indicating the body size reduction change |
Comments suppressed due to low confidence (2)
src/lib.rs:1134
- The threshold for Response has been significantly reduced from the previous value; please confirm that this new limit matches the intended behavior and that any dependent logic accounts for the change.
ensure!(Response<Body>, 250); // 136
src/body/mod.rs:100
- Wrapping BodyHandler in a Box is appropriate to reduce the size of the Body struct, but please verify that all associated pattern matches and consumers are updated for this boxed type to prevent potential runtime issues.
Handler(Box<BodyHandler>),
0c0f3c1 to
db619b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.