8000 Add indexes for groupless address columns by tdroxler · Pull Request #617 · alephium/explorer-backend · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add indexes for groupless address columns #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 22, 2025
Merged

Conversation

tdroxler
Copy link
Member

A migration is needed to drop a index that has a wrong name + it was indexing the address field too while it only need groupless_address

A migration is needed to drop a index that has a wrong name + it was
indexing the `address` field too while it only need `groupless_address`
@tdroxler tdroxler requested a review from h0ngcha0 May 20, 2025 16:36
_ <- createGrouplessAddressTimestampIndex()
} yield ()

def createGrouplessAddressTimestampIndex(): DBActionW[Int] =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Nit] Is the naming of the function correct? Seems that it creates index for groupless address and tokens.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep....copy-pasting is baaaad.... 😅

Copy link
Member
@h0ngcha0 h0ngcha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tdroxler tdroxler merged commit 321caeb into master May 22, 2025
2 of 4 checks passed
@tdroxler tdroxler deleted the groupless-indexes branch May 22, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0