8000 feat(state): Provide the next proposer in `PrepareProposalRequest` by alesforz · Pull Request #2 · alesforz/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(state): Provide the next proposer in PrepareProposalRequest #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 22 commits into
base: bera-v1.x
Choose a base branch
from
Open

feat(state): Provide the next proposer in PrepareProposalRequest #2

wants to merge 22 commits into from

Conversation

alesforz
Copy link
Owner

No description provided.

@alesforz alesforz self-assigned this Feb 11, 2025
@alesforz alesforz changed the base branch from v1.x-bera to bera-v1.x February 11, 2025 11:03
@alesforz alesforz changed the title Alesforz/next proposer in proposal Provide the next proposer in PrepareProposalRequest Feb 11, 2025
@alesforz alesforz marked this pull request as ready for review February 11, 2025 11:07
melekes
melekes reviewed Feb 11, 2025
View reviewed changes
Copy link
Collaborator
@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

can we add some tests and modify spec/abci/abci++_methods.md?

alesforz
alesforz commented Feb 13, 2025
View reviewed changes
spec/abci/abci++_methods.md Outdated
Copy link
Owner Author
@alesforz alesforz Feb 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My IDE auto-formatter made a lot of changes to this file 😓 But I checked and they did not screw up the layout of the rendered markdown file.
In any case, I've added the new field to the PrepareProposalRequest struct.

@alesforz
Formatted TestEmptyPrepareProposal
f6b0500
@alesforz
Added:
d4b0ead 
- `TestCreateProposalNextProposerAddress` to test that `CreateProposalBlock` adds
  the correct next proposer to the `PrepareProposalRequest`.
- mock `abci.Application` needed by `TestCreateProposalNextProposerAddress`.
melekes
melekes approved these changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator
@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@alesforz alesforz changed the title Provide the next proposer in PrepareProposalRequest feat(state): Provide the next proposer in PrepareProposalRequest Feb 14, 2025
alesforz and others added 9 commits February 14, 2025 15:02
@alesforz
updated go.mod to address vulnerability in crypto pkg
487f990
@alesforz
updated github actions go version
6f5970f
@alesforz
updated api go.mod to go 1.23.6
40e03a0
@alesforz
Revert "updated go.mod to address vulnerability in crypto pkg"
be2516d 
This reverts commit 487f990.

Updating Go's version should be done in its own PR.
@alesforz
Revert "updated github actions go version"
81ca82b 
This reverts commit 6f5970f.

Updating Go's version should be done in its own PR.
@alesforz
Revert "updated api go.mod to go 1.23.6"
1cbcfac 
This reverts commit 40e03a0.

Updating Go's version should be done in its own PR.
@alesforz
Added doc in PrepareProposalRequest.next_proposer_address proto def…
b79b670 
…inition.
@alesforz
regenerated protobuf
aaf44c5
@alesforz @melekes
Apply suggestions to docs from code review
9554a20 
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Signed-off-by: Alessandro Sforzin <alesforz@gmail.com>
@alesforz alesforz mentioned this pull request Mar 12, 2025
Merged
@greg-szabo greg-szabo mentioned this pull request Apr 24, 2025
Merged
3 tasks
greg-szabo added a commit to greg-szabo/cometbft that referenced this pull request Apr 24, 2025
@greg-szabo
build(deps): Address vulnerabilities
551ccb9 
Vulnerability alesforz#2: GO-2025-3447
Timing sidechannel for P-256 on ppc64le in crypto/internal/nistec
More info: https://pkg.go.dev/vuln/GO-2025-3447
Standard library
Found in: crypto/internal/nistec@go1.23.5
Fixed in: crypto/internal/nistec@go1.23.6
@greg-szabo greg-szabo mentioned this pull request Apr 24, 2025
Merged
8000 3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melekes melekes melekes approved these changes

Assignees

@alesforz alesforz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alesforz @melekes
0