Fixes #36 (Client fails to retrieve items larger than 64 KB) #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for alexzel#36
alexzel
reviewed
Oct 2, 2024
There was a problem hiding this comment.
Thanks for the contribution. Please see my comments. Also, would be good to add the corresponding test in client.test.js, but to make it work we need to increase max item size in Dockerfile:
-CMD echo $SASL_PASSWORD | saslpasswd2 -c memcached -p && exec memcached -S -u root
+CMD echo $SASL_PASSWORD | saslpasswd2 -c memcached -p && exec memcached -I 10m -S -u root|
Repro unit test added. |
alexzel
approved these changes
Oct 2, 2024
|
Please see the changes in v1.5.11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #36