8000 chore: fixed failing cleanup scripts and converted them to ts by doiron · Pull Request #471 · alexa/ask-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: fixed failing cleanup scripts and converted them to ts #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2023

Conversation

doiron
Copy link
Contributor
@doiron doiron commented May 17, 2023

Issue #, if available:

Description of changes:

functional-tests cleanup scripts have been failing since the aws sdk v3 upgrade.

fixed and converted to Typescript

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@doiron doiron force-pushed the cleanup-script-fix branch 2 times, most recently from d494c25 to 415ddda Compare May 18, 2023 16:21
@doiron doiron force-pushed the cleanup-script-fix branch from 415ddda to c37476f Compare May 18, 2023 16:25
…kill id is getting deleted before calling smapi
@doiron doiron marked this pull request as ready for review May 18, 2023 18:45
@doiron doiron requested a review from tydonelson May 18, 2023 18:45
Copy link
Contributor
@tydonelson tydonelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@doiron doiron merged commit a02b8d6 into develop May 22, 2023
@doiron doiron deleted the cleanup-script-fix branch May 22, 2023 19:42
6674
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0