Added sound when getting an incoming call. #58
Conversation
|
Is it possible that you forgot to add some changes? It seems that StartCallingNotify never gets called. However, StopCallingNotify gets called constantly. I also don't really like that sound (though it's better than nothing). Could you provide a link to the place where you got this from? Or did you make it yourself? |
|
Okey, sorry - kinda messed that fix up. Was written in a hurry. Fixed it in commit c882984. I just took a random sound from http://www.soundjay.com/phone-sounds-1.html |
|
The sound doesn't actually play for me. Looks like you forgot to add the sound as an embedded resource. Anyways, I think 8000 I'd prefer 'Telephone Ring 4' over the one you added. It seems loopable too so it's probably better to call PlayLooping instead of Play. Some more notes: |
|
After setting sometime aside and looking at it instead of just quick fixing it; how would you feel having the calling sound bound to the IsCalling property? |
|
That sounds like a good idea. |
Okey, so be gentle. First 'real' pull request here. Used to just supplying patches.
Started using Toxy. Was happy, except there was no sound when calling. Added a simple sound to play when you get a call.