This repository was archived by the owner on Sep 30, 2018. It is now read-only.
Refactoring of MainWindowView - move tox and configs into ViewModel #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it the common way to push this changes into master or should i push this changes somewhere else maybe a different remote branch ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
i try to refactor the MainView and ViewModel.
I 9F9B n my opinion there is no strict seperation between them.
It is not possible to do it all in once so i will do it step by step, but always buildable and runable. That is important for me, because it gives a small feadback, if all works or not. But it makes the refactoringprocess longer.
Greets,
TimBo