avoid self-killing on kubernetes #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
did not work :( |
|
why are you mentioning me ? i haven't had a problem like this. i used to use my both my own docker image as well as the official one without this problem. |
|
mentioned you for code-review :) so strange that your own image worked for you ... I though this fix would work ... I got it running with the label but it still kills itself :/ |
|
to be clear i've just used these images in a local dockre-compose stack, not k8s |
|
ah, that might be the difference ... I'll keep digging, no worries :D |
7e368ba to
df8887d
Compare
|
found it ... good to merge ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #62
@Dieterbe