GitHub Action to automatically generate a ZIP with the files+MSI every push #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* MXE build working, can't use a pre-compiled package as Spek needs to patch ffmpeg * it takes over ~2 hours to build, so added cache action size = ~2GB... GitHub has a 10GB limit per repo * Depedencies for MXE are the same to build Spek * Still had to use fix, paths are tweaked from alexkay#189 * Upload the build artifact for the second stage to use. This includes the windows binary, wxs, and tests
* Restore the artifacts from the first stage into the right paths, includes all the files needed to continue the build * Setup WiX, and call build.bat * Upload the MSI Artifact along with the binary files (this is what someone would actually want to download)
* Remove/update some of the debug statements. Probably still important to keep most of them. * Update the output paths so the output is tweaked
sylikc
commented
Feb 6, 2023
| run: | | ||
| # patch autogen.sh -- similar to https://github.com/alexkay/spek/issues/189 | ||
| # https://superuser.com/questions/422459/substitution-in-text-file-without-regular-expressions/422467#422467 | ||
| sed -i "s|autoreconf -fiv|autoreconf -fiv -I ../mxe/usr/x86_64-w64-mingw32.static/share/aclocal/|g" autogen.sh |
There was a problem hiding this comment.
right here, I had to patch the autogen.sh
|
@sylikc, this looks great, thank you so much! Give me a few days to review. |
|
GitHub Action Builds at each commit/push,,,,,, ain't that a bit overkill. Shouldn't this build option be set off manually. |
|
it can be set that way. But I think only the repository owner can kick off the build, which makes it only semi-automated. The build time is actually pretty quick though, because MXE is already cached, the average build time is about 6min. The first build of MXE takes 2h, but that's only done once, and cached for 30d. It also means that if the builds aren't initiated often enough, the rebuild of MXE might have to happen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alexander, as requested in #241, I've come up with a GitHub workflow that will automatically build the MSI/ZIP for Windows.
It looks like I still needed to make the patch to the
autogen.shsimilar to #189 . See line 84 in the workflow file.Let me know what you think. I can patch the version information to your preference if you want unofficial releases to show different version numbers in the about box, similar to what I do on JPEGView
Linux stage
Windows stage