fix issue 3453: bridge ParamFlow and Authority rules to Nacos correctly (#3453) #3519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orrectly (alibaba#3453) This pull request fixes issue alibaba#3453 by ensuring that ParamFlow and Authority rules published by Sentinel‑Dashboard to Nacos can be correctly parsed by Sentinel clients. In version 1.8.8 the dashboard’s entity classes and the core rule classes became out of sync, causing clients to fail to deserialize JSON and never load the rules. What was changed: 1. Introduced two “CorrectEntity” classes (ParamFlowRuleCorrectEntity and AuthorityRuleCorrectEntity) that exactly mirror the fields of the core ParamFlowRule and AuthorityRule types. 2. Registered new FastJSON Converter beans in NacosConfig for String↔List<ParamFlowRuleCorrectEntity> and String↔List<AuthorityRuleCorrectEntity>. 3. Added dedicated Nacos provider and publisher components for ParamFlow and Authority rules (ParamFlowRuleNacosProvider / ParamFlowRuleNacosPublisher and AuthorityRuleNacosProvider / AuthorityRuleNacosPublisher) that bridge between CorrectEntity JSON and the original Dashboard RuleEntity types via BeanUtils.copyProperties.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes issue #3453 by ensuring that ParamFlow and Authority rules published by Sentinel‑Dashboard to Nacos can be correctly parsed by Sentinel clients. In version 1.8.8 the dashboard’s entity classes and the core rule classes became out of sync, causing clients to fail to deserialize JSON and never load the rules.
What was changed:
ParamFlowRuleCorrectEntityAuthorityRuleCorrectEntityThese mirror the fields of the core
ParamFlowRuleandAuthorityRuletypes exactly.NacosConfigforString ↔ List<ParamFlowRuleCorrectEntity>String ↔ List<AuthorityRuleCorrectEntity>ParamFlowRuleNacosProvider/ParamFlowRuleNacosPublisherAuthorityRuleNacosProvider/AuthorityRuleNacosPublisherThese bridge between the CorrectEntity JSON and the original Dashboard
RuleEntitytypes viaBeanUtils.copyProperties.Describe what this PR does / why we need it
Sentinel‑Dashboard and Sentinel clients must share a consistent JSON schema when persisting rules in Nacos. After upgrading to 1.8.8, the Dashboard’s entity definitions drifted from the core rule classes, breaking client‑side deserialization. This PR restores compatibility so that rules published via Dashboard are correctly loaded by any Sentinel client.
Does this pull request fix one issue?
Fixes #3453
Describe how you did it
NacosConfigfor the new entity lists.Describe how to verify it
Special notes for reviews
sentinel-dashboardNacos extension.Thank you for your time and feedback!