8000 coco/fix environments when fun deploy by coco-super · Pull Request #777 · alibaba/funcraft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

coco/fix environments when fun deploy #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

coco-super
Copy link
Collaborator

No description provided.

@coco-super coco-super requested a review from tanhe123 February 17, 2020 13:14
lib/fc.js Outdated
for (let key in envs) {
if (envs.hasOwnProperty(key)) {

if (_.isObject(envs[key]) || envs[key] === '' || _.isNull(envs[key])) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

环境变量是不是可以为空字符串?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@tanhe123 tanhe123 merged commit 8f8260b into alibaba:master Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0