8000 enhance deploy framework support by tanhe123 · Pull Request #841 · alibaba/funcraft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

enhance deploy framework support #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 1, 2020
Merged

enhance deploy framework support #841

merged 8 commits into from
Apr 1, 2020

Conversation

tanhe123
Copy link
Contributor
@tanhe123 tanhe123 commented Apr 1, 2020 •
edited
Loading
  1. 增强对 express 的支持
  2. 为框架生成的 template.yml 新增 LogConfig: Auto，方便排查问题
  3. 添加 egg.js 支持
  4. 更新 spring boot 框架提示语
  5. 增强 LogConfig: Auto
    1. 创建 sls 时，即使没有设置 retry 次数，也会默认重试
    2. 自动 attach sls policy
  6. 删除创建临时域名无用的 role

@vangie vangie changed the title enhance deploy framekwrok support enhance deploy framekwork support Apr 1, 2020
@vangie vangie changed the title enhance deploy framekwork support enhance deploy framework support Apr 1, 2020
vangie
vangie suggested changes Apr 1, 2020
View reviewed changes
src/lib/definition.js Outdated
@@ -428,6 +428,10 @@ function isNasAutoConfig(nasConfig) {
return false;
}

function isLogAutoConfig(logConfig) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isLogAutoConfig => isLogConfigAuto

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/lib/fc.js Outdated
@@ -1183,6 +1189,32 @@ async function transformLogConfig(logConfig) {
};
}

// make sure sls project and logstore is created
async function doMakeServiceWithSlsRetry(serviceName, options, create, fcClient) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doMakeServiceWithSlsRetry => retryUntilSlsCreated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/lib/frameworks/egg.js Outdated
'actions': [
{
'condition': true,
'description': 'use npx nuxt to start server',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的描述对么？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@tanhe123 tanhe123 merged commit 392765f into master Apr 1, 2020
@tanhe123
Copy link
Contributor Author
tanhe123 commented Apr 3, 2020

#817

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vangie vangie vangie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tanhe123 @vangie
0