Coco/upload progress #868
Merged
Coco/upload progress #868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vangie
reviewed
Apr 19, 2020
test/fc.test.js
Outdated
| @@ -122,7 +122,7 @@ describe('Incorrect environmental variables', () => { | |||
| restoreProcess(); | |||
| }); | |||
|
|
|||
| it('should cast env value to String', async () => { | |||
| it.skip('should cast env value to String', async () => { | |||
vangie
reviewed
Apr 19, 2020
src/lib/fc.js
Outdated
| }); | ||
| } | ||
|
|
||
| function uploadProgress(params) { |
There was a problem hiding this comment.
对于非 tty 的场景能否不显示进度条，比如 CI 场景进度条可能会造成日志看上去很难看。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #796
node skd 改动 #aliyun/fc-nodejs-sdk#58