支持部署 war #889
Merged
支持部署 war #889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanhe123
reviewed
Apr 26, 2020
ChanDaoH
reviewed
Apr 26, 2020
ChanDaoH
approved these changes
Apr 26, 2020
tanhe123
reviewed
Apr 26, 2020
| const updateFunIgnoreProcessor = { | ||
| 'type': 'function', | ||
| 'function': async (codeDir, baseDir) => { | ||
| updateIgnore(baseDir, [ |
There was a problem hiding this comment.
为啥要把 funignore 放到 baseDir 里面？我理解，funignore 是相对于 CodeUri 的
There was a problem hiding this comment.
我看之前的代码里不支持 CodeUri 里的 funignore，你看看 src/lib/pacakge/ignore.js
const ignoreFilePath = `${baseDir}/.funignore`;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.