coco/fix node archiver repackaging files #897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vangie
reviewed
Apr 28, 2020
| @@ -98,7 +98,8 @@ async function zipFolder(zipArchiver, folder, folders, funignore, codeUri, prefi | |||
| if (!_.isEmpty(relative)) { | |||
| zipArchiver.append(null, { | |||
| name: relative, | |||
| type: 'directory' | |||
| type: 'directory', | |||
| prefix | |||
There was a problem hiding this comment.
�是漏掉了，缺少 prefix ，压缩 zip 的内容不正确导致解压 zip 时目录出现重复
| @@ -172,7 +172,7 @@ function convertZones(nasZones, zones, storageType = 'Performance') { | |||
| const vswitchId = zones.filter(f => { return f.zoneId === zoneId; }); | |||
| return { | |||
| zoneId, | |||
| vswitchId, | |||
| vswitchId: _.head(vswitchId).vswitchId, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #838