fix: k8s resource nil point #2216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
messixukejia
approved these changes
May 14, 2025
| @@ -23,7 +23,11 @@ func (m *metaCollector) processDeploymentEntity(data *k8smeta.ObjectWrapper, met | |||
| log.Contents.Add("labels", m.processEntityJSONObject(obj.Labels)) | |||
| log.Contents.Add("annotations", m.processEntityJSONObject(obj.Annotations)) | |||
| log.Contents.Add("match_labels", m.processEntityJSONObject(obj.Spec.Selector.MatchLabels)) | |||
| log.Contents.Add("replicas", strconv.FormatInt(int64(*obj.Spec.Replicas), 10)) | |||
| if obj.Spec.Replicas != nil { | |||
| log.Contents.Add("replicas", strconv.FormatInt(int64(*obj.Spec.Replicas), 10)) | |||
| @@ -209,7 +209,11 @@ func (m *metaCollector) processPersistentVolumeEntity(data *k8smeta.ObjectWrappe | |||
| log.Contents.Add("status", string(obj.Status.Phase)) | |||
| log.Contents.Add("storage_class_name", obj.Spec.StorageClassName) | |||
| log.Contents.Add("persistent_volume_reclaim_policy", string(obj.Spec.PersistentVolumeReclaimPolicy)) | |||
| log.Contents.Add("volume_mode", string(*obj.Spec.VolumeMode)) | |||
| if obj.Spec.VolumeMode != nil { | |||
There was a problem hiding this comment.
这个字段的类型是type VolumeMode string 特殊的，没有可以复用的地方
There was a problem hiding this comment.
其他保留if else的都是这个原因
linrunqi08
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
问题
K8s资源中，这类虽然有默认值的指针，在通过client-go获取时仍然可能是空的。
解决方案