feat: add instance labels into host monitor metrics #2226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
messixukejia
approved these changes
May 22, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to tag host monitor metrics with instance and user labels for the enterprise version and with a host IP label for the open-source version.
- Added a new method AddHostLabels in HostMonitorInputRunner to assign labels.
- Introduced new constants for default tag names in both enterprise and open-source modes.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| core/host_monitor/HostMonitorInputRunner.h | Added declaration of AddHostLabels method |
| core/host_monitor/HostMonitorInputRunner.cpp | Calls AddHostLabels to tag metrics and implements label assignment |
| core/host_monitor/Constants.h | Added declaration of new label constants under conditional macros |
| core/host_monitor/Constants.cpp | Defined the new label constants for enterprise and open-source builds |
yyuuttaaoo
reviewed
Jun 1, 2025
yyuuttaaoo
reviewed
Jun 1, 2025
| @@ -197,4 +209,30 @@ void HostMonitorInputRunner::PushNextTimerEvent(const std::chrono::steady_clock: | |||
| Timer::GetInstance()->PushEvent(std::move(event)); | |||
| } | |||
|
|
|||
| void HostMonitorInputRunner::AddHostLabels(PipelineEventGroup& group) { | |||
| #ifdef __ENTERPRISE__ | |||
| auto userID = group.GetSourceBuffer()->CopyString(EnterpriseConfigProvider::GetInstance()->GetAliuidSet()); | |||
There was a problem hiding this comment.
应该取ECS Meta中的user id
yyuuttaaoo
approved these changes
Jun 6, 2025
WRPStephanie
pushed a commit
to WRPStephanie/loongcollector
that referenced
this pull request
Jun 20, 2025
* feat: add instance labels into host monitor metrics
xiongyunn
pushed a commit
to xiongyunn/loongcollector
that referenced
this pull request
Jun 27, 2025
* feat: add instance labels into host monitor metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
商业版主机监控指标默认添加 instance_id 和 user_id 两个标签。
开源版主机监控指标默认添加 host_ip 标签。
TODO
对于Label的处理，后续Loongcollector SPL支持处理Metric后，可以通过SPL进行删除和重命名