feat: support send multivalue metrics to sls #2233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
messixukejia
requested changes
May 24, 2025
| @@ -505,7 +508,8 @@ bool FlusherSLS::Init(const Json::Value& config, Json::Value& optionalGoPipeline | |||
| this, | |||
| strategy, | |||
| !mContext->IsExactlyOnceEnabled() && mShardHashKeys.empty() | |||
| && mTelemetryType != sls_logs::SLS_TELEMETRY_TYPE_METRICS)) { | |||
| && mTelemetryType != sls_logs::SLS_TELEMETRY_TYPE_METRICS | |||
There was a problem hiding this comment.
用函数或宏封装下，赋予含义，不要直接罗列判断条件
函数名即注释
There was a problem hiding this comment.
SLS_TELEMETRY_TYPE_APM_METRICS 为什么没有？
There was a problem hiding this comment.
这个APM的目前没什么问题。 @KayzzzZ 后续会测试再提PR
yyuuttaaoo
reviewed
Jun 2, 2025
There was a problem hiding this comment.
Pull Request Overview
Add support for sending multi-value and host metrics to SLS MetricStore by extending the serializer, client manager, and flusher components, and by adding unit tests and protobuf enum entries.
- Extended SLSSerializer and LogGroupSerializer to calculate and emit multi-value metric fields.
- Introduced new telemetry types (
metrics_multivalue,metrics_host) insls_logs.proto, constants, client manager, and flusher logic. - Added unit tests for multi-value metrics and fixed a typo in
MetricsValueAPI.
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| core/unittest/serializer/SLSSerializerUnittest.cpp | Added CreateBatchedMultiValueMetricEvents and tests for various tag/value combos. |
| core/unittest/flusher/FlusherSLSUnittest.cpp | Added config test for metrics_multivalue telemetry type. |
| core/protobuf/sls/sls_logs.proto | Added SLS_TELEMETRY_TYPE_METRICS_MULTIVALUE and METRICS_HOST. |
| core/plugin/flusher/sls/SLSConstant.h/.cpp | Defined new HOSTMETRICS constant for host metrics path. |
| core/plugin/flusher/sls/SLSClientManager.h/.cpp | Added PreparePostHostMetricsRequest to build host metrics requests. |
| core/plugin/flusher/sls/FlusherSLS.h/.cpp | Added CreatePostHostMetricsRequest, ShouldGroupBatch, and telemetry branching. |
| core/plugin/flusher/sls/DiskBufferWriter.cpp | Included METRICS_MULTIVALUE in the switch for dispatch. |
| core/models/MetricValue.h/.cpp | Renamed ValusSize to ValuesSize. |
| core/collection_pipeline/serializer/SLSSerializer.h/.cpp | Extended serializer to support multi-value metric size calculation and serialization. |
messixukejia
reviewed
Jun 6, 2025
| req = CreatePostLogStoreLogsRequest(accessKeyId, accessKeySecret, type, data); | ||
| break; | ||
| case sls_logs::SLS_TELEMETRY_TYPE_METRICS_HOST: | ||
| req = CreatePostHostMetricsRequest(accessKeyId, accessKeySecret, type, data); | ||
| break; | ||
| case sls_logs::SLS_TELEMETRY_TYPE_METRICS: |
There was a problem hiding this comment.
SLS_TELEMETRY_TYPE_APM_AGENTINFOS jq
yyuuttaaoo
approved these changes
Jun 6, 2025
messixukejia
approved these changes
Jun 9, 2025
wardenjohn
pushed a commit
to wardenjohn/loo-zyd
that referenced
this pull request
Jun 18, 2025
* feat: support send multivalue metrics to sls * fix * fix * fix * fix * fix
xiongyunn
pushed a commit
to xiongyunn/loongcollector
that referenced
this pull request
Jun 27, 2025
* feat: support send multivalue metrics to sls * fix * fix * fix * fix * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
支持flusher_sls写入SLS MetricStore多值接口
接口介绍
SLS MetricStore多值接口与日志接口相同。除此之外，针对多值指标有一些额外的规则：