feat: support dynamic label values and global metrics record. #2268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I0ed79c684700adfd35d0ec67385e1b5abc22aaa6
Change-Id: I7dbb706bb72494d5aff7d0be6c1732a56fe421fd
Takuka0311
requested changes
Jun 24, 2025
| // A metric may have three levels of labels | ||
| // 1. MetricsRecord Level Const Labels, like PluginType=flusher_http, PluginId=1 | ||
| // 2. Metric Level Const Labels, for example, flusher_http may have a const label: RemoteURL=http://aliyun.com/write | ||
| // 3. Metric Level Dynamic Labels, like status_code=200, status_code=204 |
There was a problem hiding this comment.
是不是可以这样理解：
- MetricsRecord级别有一些label，也有一些没有自己label的metrics，他们会输出一个metric记录，也就是Line45这一条
- 每个Metric会有自己的一些const和Dynamic label，当有这些label时，一个metric会变成一条单独的metric记录被暴露出来，例如上面的http_flusher_status_code_count * 2，http_flusher_error_count * 3？
There was a problem hiding this comment.
指标是有类型的，go这边key是metric_category，value是agent、runner、这些。https://observability.cn/project/loongcollector/internal-metrics-description/#_top
具有单独label的Metric，是不是需要定义为plugin_source级？这块有考虑过吗
| @@ -27,6 +30,27 @@ const ( | |||
| MetricExportTypeCpp = "cpp_provided" | |||
| ) | |||
|
|
|||
| var globalMetricRecord = globalMetricRecords{records: make(map[*selfmonitor.MetricsRecord]struct{})} | |||
There was a problem hiding this comment.
这里的global metric有例子吗？如果是全局级别的（agent级，现有的在pkg/selfmonitor/metrics_constants_agent.go）的指标，要添加到C++部分一起输出的。
还是说这些指标不是agent级，而是某些单例？单例的话可以参考k8s_meta这里的实现，是runner级的，指标等级一定要有
There was a problem hiding this comment.
是的，单例，我加一下runner
| // 1. MetricsRecord Level Const Labels, like PluginType=flusher_http, PluginId=1 | ||
| // 2. Metric Level Const Labels, for example, flusher_http may have a const label: RemoteURL=http://aliyun.com/write | ||
| // 3. Metric Level Dynamic Labels, like status_code=200, status_code=204 | ||
| func (m *MetricsRecord) ExportMetricRecords() []map[string]string { |
There was a problem hiding this comment.
方便给一个前后对比吗？先前有问题的指标和修改之后的样子
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.