8000 on embedded derby storage on standalone model ，config cas update not work · Issue #9943 · alibaba/nacos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

on embedded derby storage on standalone model ，config cas update not work #9943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shiyiyue1102 opened this issue Feb 14, 2023 · 0 comments
Closed

on embedded derby storage on standalone model ，config cas update not work #9943

shiyiyue1102 opened this issue Feb 14, 2023 · 0 comments
Labels
area/Config kind/bug Category issues or prs related to bug.
Milestone
2.2.1

Comments

@shiyiyue1102
Copy link
Collaborator
shiyiyue1102 commented Feb 14, 2023 •
edited
Loading

on embedded derby storage on standalone model ，config cas update not work.

Describe the bug

com.alibaba.nacos.config.server.service.repository.PersistService#updateConfigInfoCas
where current md5 is not match ,config cas update method should return update fail.
ExternalConfigInfoPersistServiceImpl works ,but EmbeddedConfigInfoPersistServiceImpl works.

Expected behavior
where BaseDatabaseOperate update method executing modified requests, it should check the number of rows affected

Actually behavior
it seems that BaseDatabaseOperate update do not recognized the update result value ,so when cas check fail ,updateConfigInfoCas method return true still.

If someone interested in this issue ,create pull request to solve it.
@shiyiyue1102 shiyiyue1102 added kind/bug Category issues or prs related to bug. area/Config labels Feb 14, 2023
@KomachiSion KomachiSion added this to the 2.2.1 milestone Feb 14, 2023
karsonto added a commit to karsonto/nacos that referenced this issue Feb 14, 2023
@karsonto
fix issue alibaba#9943
71e1bdc
@karsonto karsonto mentioned this issue Feb 15, 2023
Merged
5 tasks
shiyiyue1102 pushed a commit that referenced this issue Mar 3, 2023
@karsonto
[ISSUE #9943] Resolve issue Config cas update not work (#9952)
e58c444 
* fix issue 9943

* add some description

* add some log for roll back transaction

* add some log for roll back transaction

* set default rollBackOnUpdateFail false.

* format style

* fix some bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/Config kind/bug Category issues or prs related to bug.
Projects
None yet
Milestone
2.2.1
Development

No branches or pull requests
2 participants
@shiyiyue1102 @KomachiSion
0