8000 fix #3215 bug by improve code quality for client. by caojiele · Pull Request #6050 · alibaba/nacos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix #3215 bug by improve code quality for client. #6050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 15, 2021
Merged

fix #3215 bug by improve code quality for client. #6050

merged 9 commits into from
Jun 15, 2021

Conversation

caojiele
Copy link
Contributor

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fix #3215 bug by improve code quality for client.

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@CLAassistant
Copy link
CLAassistant commented Jun 11, 2021 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ caojiele
❌ iamtianxuan
You have signed the CLA already but the status is still pending? Let us recheck it.

horizonzy
horizonzy reviewed Jun 11, 2021
View reviewed changes
Copy link
Collaborator
@horizonzy horizonzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line indent should be fix.

@KomachiSion KomachiSion merged commit 4df0cd0 into alibaba:develop Jun 15, 2021
@KomachiSion KomachiSion added this to the 2.0.3 milestone Jun 15, 2021
@KomachiSion KomachiSion added area/Config kind/enhancement Category issues or prs related to enhancement. labels Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@horizonzy horizonzy horizonzy left review comments

@KomachiSion KomachiSion KomachiSion approved these changes

Assignees
No one assigned
Labels
area/Config kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Milestone
2.0.3
Development

Successfully merging this pull request may close these issues.

Nacos 订阅者列表应用名unknown
5 participants
@caojiele @CLAassistant @horizonzy @KomachiSion @iamtianxuan
0