8000 improvement performance by wuwen5 · Pull Request #6407 · alibaba/nacos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

improvement performance #6407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2021
Merged

improvement performance #6407

merged 1 commit into from
Jul 22, 2021

Conversation

wuwen5
Copy link
Contributor
@wuwen5 wuwen5 commented Jul 21, 2021

improvement performance

Set the log level to warn, but new SimpleDateFormat(DATETIME_PATTERN)).format(new Date(this.lastTime)) always executes.

Benchmark                     Mode  Cnt       Score        Error  Units
Test.ori                   thrpt    5  535988.141 ± 105961.666  ops/s
Test.useIsDebugEnabled     thrpt    5  3903584.317 ± 590721.088  ops/s

@KomachiSion KomachiSion merged commit 4d7ccd5 into alibaba:develop Jul 22, 2021
zrlw added a commit to zrlw/nacos that referenced this pull request Jan 10, 2022
@zrlw
apply pull alibaba#6407 to check debug enabled status before logging
4179543
zrlw added a commit to zrlw/nacos that referenced this pull request Feb 21, 2022
@zrlw
apply PR alibaba#6407 to check debug enabled status before logging
059482f
@zrlw zrlw mentioned this pull request Feb 21, 2022
Merged
KomachiSion pushed a commit that referenced this pull request Feb 24, 2022
@zrlw
apply PR #6407 to check debug enabled status before logging (#7808)
df1a01d
CherishCai pushed a commit to CherishCai/nacos that referenced this pull request Apr 12, 2022
@zrlw @CherishCai
apply PR alibaba#6407 to check debug enabled status before logging (a…
7164568 
…libaba#7808)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

5577 @KomachiSion KomachiSion KomachiSion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wuwen5 @KomachiSion
0