8000 [ISSUE #7593]修复集群模式使用内置数据库配置中心配置文件丢失 by ccoke · Pull Request #7612 · alibaba/nacos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[ISSUE #7593]修复集群模式使用内置数据库配置中心配置文件丢失 #7612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

ccoke
Copy link
@ccoke ccoke commented Jan 10, 2022

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

修复集群模式使用内置数据库配置中心配置文件丢失

Brief changelog

XX

Verifying this change

改为:判断本地数据库和内存缓存中的数据一致,且判断磁盘中是否有对应文件成立才不写磁盘,否则还是继续写磁盘。

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@CLAassistant
Copy link
CLAassistant commented Jan 10, 2022

CLA assistant check
All committers have signed the CLA.

@chuntaojun chuntaojun linked an issue Jan 12, 2022 that may be closed by this pull request
@chuntaojun
Copy link
Collaborator

LGTM

8000
@MajorHe1
Copy link
Collaborator

I think same changes should be added to dumpTag() and dumpBeta(), and merge to develop branch as well.

@chuntaojun chuntaojun added area/Config kind/bug Category issues or prs related to bug. labels Jan 12, 2022
@chuntaojun chuntaojun modified the milestones: 2.1.0, 1.4.3 Jan 12, 2022
@chuntaojun chuntaojun merged commit f0b1102 into alibaba:v1.x-develop Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Config kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

集群模式+内置数据库配置中心配置文件丢失
4 participants
0