8000 [ISSUE #8072] Fix checkstyle error by liqipeng · Pull Request #8119 · alibaba/nacos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[ISSUE #8072] Fix checkstyle error #8119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2022
Merged

[ISSUE #8072] Fix checkstyle error #8119

merged 1 commit into from
Apr 11, 2022

Conversation

liqipeng
Copy link
Contributor
@liqipeng liqipeng commented Apr 9, 2022

What is the purpose of the change

I find out PR #8075 makes checkstyle failed and create this PR to fix the error and also and migrate JacksonUtils unit test from develop(for v2.x) branch to v1.x-develop.

发现之前提的PR #8075 导致了checkstyle失败，所以创建了这个新的PR修复错误，并且顺便把2.x分支的JacksonUtils的单元测试迁移到了1.x分支。

Error detail: https://github.com/alibaba/nacos/runs/5844257313

Error:  /home/runner/work/nacos/nacos/common/src/test/java/com/alibaba/nacos/common/utils/JacksonUtilsTest.java:13: First sentence of Javadoc is missing an ending period. [SummaryJavadoc]
Error:  /home/runner/work/nacos/nacos/common/src/test/java/com/alibaba/nacos/common/utils/JacksonUtilsTest.java:57:100: '{' is not followed by whitespace. [WhitespaceAround]
Error:  /home/runner/work/nacos/nacos/common/src/test/java/com/alibaba/nacos/common/utils/JacksonUtilsTest.java:57:101: '}' is not preceded with whitespace. [WhitespaceAround]

Brief changelog

Fix checkstyle error and migrate JacksonUtils unit test from develop(for v2.x) branch to v1.x-develop.

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@KomachiSion KomachiSion merged commit 92053b5 into alibaba:v1.x-develop Apr 11, 2022
CherishCai pushed a commit to CherishCai/nacos that referenced this pull request Apr 12, 2022
@liqipeng @CherishCai
Fix checkstyle error and migrate JacksonUtils unit test from `develop…
33a5fb5 
…`(for v2.x) branch to `v1.x-develop`. (alibaba#8072) (alibaba#8119)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KomachiSion KomachiSion KomachiSion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liqipeng @KomachiSion
0