8000 remove unused static import by Roger3581321 · Pull Request #8512 · alibaba/nacos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

remove unused static import #8512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

remove unused static import #8512

wants to merge 1 commit into from

Conversation

Roger3581321
Copy link
Contributor
@Roger3581321 Roger3581321 commented Jun 5, 2022 •
edited
Loading

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

remove unused static import by reference to #8000.

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@codecov-commenter
Copy link

Codecov Report

Merging #8512 (d5d769e) into develop (d8238de) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #8512      +/-   ##
=============================================
+ Coverage      41.10%   41.24%   +0.14%     
- Complexity      4383     4394      +11     
=============================================
  Files            876      876              
  Lines          31862    31868       +6     
  Branches        3709     3709              
=============================================
+ Hits           13096    13144      +48     
+ Misses         17453    17406      -47     
- Partials        1313     1318       +5
Impacted Files Coverage Δ
...a/com/alibaba/nacos/api/grpc/auto/RequestGrpc.java 0.00% <ø> (ø)
...aba/nacos/client/config/http/MetricsHttpAgent.java 100.00% <100.00%> (ø)
...m/alibaba/nacos/client/monitor/MetricsMonitor.java 90.90% <100.00%> (ø)
.../naming/push/v2/NamingSubscriberServiceV2Impl.java 74.41% <0.00%> (-11.63%) ⬇️
...ing/core/v2/index/ClientServiceIndexesManager.java 63.93% <0.00%> (-9.84%) ⬇️
...a/nacos/client/naming/backups/FailoverReactor.java 30.83% <0.00%> (-9.17%) ⬇️
...com/alibaba/nacos/naming/core/v2/pojo/Service.java 72.41% <0.00%> (-6.90%) ⬇️
...cos/naming/core/v2/event/service/ServiceEvent.java 93.33% <0.00%> (-6.67%) ⬇️
...baba/nacos/client/auth/ram/identify/StsConfig.java 66.66% <0.00%> (-5.13%) ⬇️
...s/client/naming/core/ServiceInfoUpdateService.java 64.93% <0.00%> (-2.60%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e66a190...d5d769e. Read the comment docs.

KomachiSion
KomachiSion requested changes Jun 6, 2022
View reviewed changes
Copy link
Collaborator
@KomachiSion KomachiSion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please no change auto generate classes

@KomachiSion KomachiSion closed this Jun 6, 2022
@KomachiSion KomachiSion added the status/invalid This doesn't seem right label Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KomachiSion KomachiSion KomachiSion requested changes

Assignees
No one assigned
Labels
status/invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Roger3581321 @codecov-commenter @KomachiSion
0