8000 Add exception detail stacks when connect to server failed. by KomachiSion · Pull Request #8801 · alibaba/nacos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add exception detail stacks when connect to server failed. #8801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

KomachiSion
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

Print detail exception info to log when connect to nacos server failed.

Brief changelog

Add exception detail stacks when connect to server failed.

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@codecov-commenter
Copy link

Codecov Report

Merging #8801 (b0af808) into develop (34bbd38) will increase coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #8801      +/-   ##
=============================================
+ Coverage      43.25%   43.28%   +0.03%     
+ Complexity      4713     4711       -2     
=============================================
  Files            904      904              
  Lines          32504    32504              
  Branches        3751     3751              
=============================================
+ Hits           14058    14069      +11     
+ Misses         17095    17085      -10     
+ Partials        1351     1350       -1     
Impacted Files Coverage Δ
.../alibaba/nacos/common/remote/client/RpcClient.java 35.30% <0.00%> (ø)
.../naming/push/v1/NamingSubscriberServiceV1Impl.java 66.66% <0.00%> (-15.88%) ⬇️
.../core/v2/event/publisher/NamingEventPublisher.java 75.00% <0.00%> (-1.25%) ⬇️
...m/alibaba/nacos/core/remote/ConnectionManager.java 37.86% <0.00%> (-1.19%) ⬇️
...a/com/alibaba/nacos/naming/push/v1/PushClient.java 46.93% <0.00%> (ø)
...baba/nacos/naming/healthcheck/HealthCheckTask.java 48.52% <0.00%> (+1.47%) ⬆️
.../nacos/naming/healthcheck/ClientBeatCheckTask.java 31.81% <0.00%> (+1.51%) ⬆️
...alibaba/nacos/client/config/impl/ClientWorker.java 54.97% <0.00%> (+4.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34bbd38...b0af808. Read the comment docs.

@MajorHe1 MajorHe1 merged commit ff336d9 into alibaba:develop Jul 26, 2022
@KomachiSion KomachiSion deleted the develop-client-detail-exception branch July 26, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0