8000 [ISSUE #9271] fix 'JraftServer' npe log by yann9 · Pull Request #9272 · alibaba/nacos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[ISSUE #9271] fix 'JraftServer' npe log #9272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2022
Merged

[ISSUE #9271] fix 'JraftServer' npe log #9272

merged 1 commit into from
Oct 10, 2022

Conversation

yann9
Copy link
Contributor
@yann9 yann9 commented Oct 8, 2022

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fix #9271

Brief changelog

Do not continuous cliService.getPeers after server shutdown

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@CLAassistant
Copy link
CLAassistant commented Oct 8, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@KomachiSion KomachiSion added the kind/enhancement Category issues or prs related to enhancement. label Oct 10, 2022
@KomachiSion KomachiSion added this to the 2.1.2 milestone Oct 10, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #9272 (07defa4) into develop (5396858) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #9272      +/-   ##
=============================================
+ Coverage      44.08%   44.15%   +0.07%     
- Complexity      4858     4861       +3     
=============================================
  Files            913      913              
  Lines          33047    33049       +2     
  Branches        3825     3825              
=============================================
+ Hits           14569    14594      +25     
+ Misses         17059    17036      -23     
  Partials        1419     1419
Impacted Files Coverage Δ
...ibaba/nacos/core/distributed/raft/JRaftServer.java 61.75% <100.00%> (+0.30%) ⬆️
...alibaba/nacos/core/remote/control/TpsRecorder.java 74.32% <0.00%> (-1.36%) ⬇️
...alibaba/nacos/client/config/impl/ClientWorker.java 55.16% <0.00%> (-0.20%) ⬇️
.../core/v2/event/publisher/NamingEventPublisher.java 76.25% <0.00%> (+1.25%) ⬆️
...m/alibaba/nacos/core/remote/ConnectionManager.java 44.37% <0.00%> (+1.47%) ⬆️
...os/client/auth/ram/identify/CredentialService.java 82.69% <0.00%> (+3.84%) ⬆️
...libaba/nacos/core/cluster/ServerMemberManager.java 76.95% <0.00%> (+4.78%) ⬆️
...m/alibaba/nacos/naming/misc/HttpClientManager.java 83.33% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5396858...07defa4. Read the comment docs.

@KomachiSion KomachiSion merged commit c191d7a into alibaba:develop Oct 10, 2022
@yann9 yann9 deleted the fix-jraft-npe branch October 14, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KomachiSion KomachiSion KomachiSion approved these changes

Assignees
No one assigned
Labels
kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Milestone
2.1.2
Development

Successfully merging this pull request may close these issues.

Jraft produce a lot of "java.lang.NullPointerException: null" after server exceptionally shutdown
4 participants
@yann9 @CLAassistant @codecov-commenter @KomachiSion
0