8000 [ISSUE #9970] Fix Nacos LoggerContext Using Slf4j LoggerFactory by ruansheng8 · Pull Request #9971 · alibaba/nacos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[ISSUE #9970] Fix Nacos LoggerContext Using Slf4j LoggerFactory #9971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[ISSUE #9970] Fix Nacos LoggerContext Using Slf4j LoggerFactory #9971

wants to merge 1 commit into from

Conversation

ruansheng8
Copy link
Contributor

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

Fixed #9970

@codecov-commenter
Copy link

Codecov Report

Merging #9971 (9850b32) into develop (9ebf5ae) will increase coverage by 0.01%.
The diff coverage is 16.66%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #9971      +/-   ##
=============================================
+ Coverage      50.68%   50.69%   +0.01%     
- Complexity      4842     4845       +3     
=============================================
  Files            861      861              
  Lines          27445    27450       +5     
  Branches        3031     3031              
=============================================
+ Hits           13910    13917       +7     
+ Misses         12311    12304       -7     
- Partials        1224     1229       +5
Impacted Files Coverage Δ
...os/client/logging/logback/LogbackNacosLogging.java 15.62% <16.66%> (+0.81%) ⬆️
...ing/core/v2/event/client/ClientOperationEvent.java 85.71% <0.00%> (-14.29%) ⬇️
...m/alibaba/nacos/naming/misc/HttpClientManager.java 50.00% <0.00%> (-8.58%) ⬇️
...cos/core/distributed/id/SnowFlowerIdGenerator.java 61.36% <0.00%> (-4.55%) ⬇️
...ing/core/v2/index/ClientServiceIndexesManager.java 55.22% <0.00%> (-4.48%) ⬇️
...os/client/auth/ram/identify/CredentialService.java 71.73% <0.00%> (-4.35%) ⬇️
...ibaba/nacos/core/distributed/raft/JRaftServer.java 60.95% <0.00%> (-0.80%) ⬇️
...os/core/cluster/lookup/FileConfigMemberLookup.java 65.21% <0.00%> (ø)
...libaba/nacos/core/cluster/ServerMemberManager.java 70.33% <0.00%> (+0.47%) ⬆️
...nacos/naming/healthcheck/v2/HealthCheckTaskV2.java 68.60% <0.00%> (+1.16%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ebf5ae...9850b32. Read the comment docs.

@ruansheng8 ruansheng8 changed the title [ISSUE #9970] fix logback loggerContext [ISSUE #9970] Fix Nacos LoggerContext Using Slf4j LoggerFactory Feb 18, 2023
@ruansheng8 ruansheng8 mentioned this pull request Feb 20, 2023
Closed
@ruansheng8
Copy link
Contributor Author

Related #9934

@ruansheng8 ruansheng8 closed this Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nacos LoggerContext Using Slf4j LoggerFactory
2 participants
@ruansheng8 @codecov-commenter
0