长轮询参数校验逻辑，修复不存在的空命名空间配置校验失败bug #11442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #11442 +/- ##
=============================================
- Coverage 61.63% 61.62% -0.01%
Complexity 6826 6826
=============================================
Files 1060 1060
Lines 31408 31408
Branches 3250 3250
=============================================
- Hits 19358 19356 -2
- Misses 10701 10705 +4
+ Partials 1349 1347 -2 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
KomachiSion
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
长轮询参数校验逻辑，修复不存在的空命名空间配置校验失败bug
Brief changelog
服务端参数校验时的逻辑是单个配置的字段数不少于3并且不大于4
客户端拼接长轮询参数时，格式是 dataId+group+md5+namespace，但是空命名空间下，namespace是空值，如果配置不存在，md5也为空，这种情况下单个配置的字段数通过split之后的数量是2，导致参数校验失败，长轮询接口报400
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=trueto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.