Make User generic in OIDC Request class #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @shawnz . Thank you very much for your contribution and sorry for being late! I will review ASAP. |
aliev
approved these changes
Aug 17, 2024
|
No worries, I'm not in any rush with these changes. Thanks for looking into this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new OIDC BaseRequest class which is generic on the User type, unlike the existing OIDC Request class which hardcodes the User type to Any. This allows you to create a subclass of BaseRequest with a particular User type, just like you can do with the non-OIDC version of the BaseRequest class.
This is the same change as in #95 but with some extra commits removed that were accidentally included in the other PR. Sorry about that