8000 Fix error in with_processors by anubisthejackle · Pull Request #131 · alleyinteractive/logger · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix error in with_processors #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix error in with_processors #131

wants to merge 2 commits into from
+9 −3

Conversation

anubisthejackle
Copy link
@anubisthejackle anubisthejackle commented May 20, 2025< 8000 /relative-time> •
edited
Loading

This fixes an issue with with_processors where Monolog was throwing a LogicException when attempting to pop off an empty stack. It also fixes an issue where monolog was throwing an error when attempting to push an array to pushProcessor instead of an individual processor class.

Fixes #132

@anubisthejackle anubisthejackle mentioned this pull request May 20, 2025
Open
nikkifurls
nikkifurls approved these changes May 20, 2025
View reviewed changes
Copy link
@nikkifurls nikkifurls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦞

@anubisthejackle anubisthejackle requested a review from srtfisher May 21, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srtfisher srtfisher srtfisher approved these changes

@nikkifurls nikkifurls nikkifurls approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fatal error when using with_processors
3 participants
@anubisthejackle @srtfisher @nikkifurls
0