8000 TransformerTextField in the MC models by dirkgr · Pull Request #286 · allenai/allennlp-models · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Dec 16, 2022. It is now read-only.

TransformerTextField in the MC models #286

Merged
merged 21 commits into from
Jul 8, 2021
Merged

TransformerTextField in the MC models #286

merged 21 commits into from
Jul 8, 2021

Conversation

dirkgr
Copy link
Member
@dirkgr dirkgr commented Jun 24, 2021

This depends on allenai/allennlp#5280 being merged first.

@dirkgr dirkgr self-assigned this Jun 24, 2021
@dirkgr
Copy link
Member Author
dirkgr commented Jun 24, 2021

PIQA performs significantly worse in this branch. I'll have to find out why before merging.

@dirkgr dirkgr marked this pull request as ready for review July 8, 2021 00:38
@dirkgr dirkgr requested a review from epwalsh July 8, 2021 00:38
epwalsh
epwalsh reviewed Jul 8, 2021
View reviewed changes
allennlp_models/mc/models/transformer_mc.py Outdated
@@ -89,6 +90,8 @@ def forward( # type: ignore
best_alternative : ``List[int]``
The index of the highest scoring alternative for every instance in the batch
"""
self.eval() # DEBUG
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left over from debugging?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱

allennlp_models/mc/models/transformer_mc.py Outdated
@@ -53,6 +53,7 @@ def __init__(
)

self._linear_layer = torch.nn.Linear(self._text_field_embedder.get_output_dim(), 1)
torch.manual_seed(1234)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left over from debugging?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙀

epwalsh
epwalsh approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member
@epwalsh epwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dirkgr dirkgr merged commit 698b7ef into main Jul 8, 2021
@dirkgr dirkgr deleted the TransformerTextField branch July 8, 2021 22:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@epwalsh epwalsh epwalsh approved these changes

Assignees

@dirkgr dirkgr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dirkgr @epwalsh
0