This repository was archived by the owner on Dec 16, 2022. It is now read-only.
be friendlier to windows users #1572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeNeutoy
approved these changes
Aug 6, 2018
|
I don't know that we'll ever officially support it, I just want to make it easier for the people who are clamoring for it |
|
but if I ever get it working end-to-end I'll look into a CI way of making sure it stays working |
gabrielStanovsky
pushed a commit
to gabrielStanovsky/allennlp
that referenced
this pull request
Sep 7, 2018
* be friendlier to windows users * conditional import for resource * get things in the right order
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these are small things that prevent allennlp from running on windows, this isn't all the way to getting it to work, but it's a step in that direction:
(1) jsonnet won't pip install on windows right now, so I disabled it in
requirements.txtif the platform is windows(2) accordingly, in
params.pywe wrap theimport _jsonnetin a try-catch block, and if it can't be imported we stub in alternative functions that log a warning and assume the configuration is pure JSON(3) the
resourcemodule doesn't exist on Windows, so inutil.pywe import it conditionally, and then we check that it's there before we use it(4) on unix, urlparse.scheme is an empty string for a file, but on windows it isn't, so I just removed that check in
cached_path, it should be fine to just check if the file exists whatever the scheme is