This repository was archived by the owner on Dec 16, 2022. It is now read-only.
Remove bucket iterator shuffle warning. #1742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From discussion here: allenai#1578. Let me know if I should remove the code instead of commenting it.
matt-gardner
reviewed
8000
Sep 10, 2018
| else: | ||
| logger.warning("shuffle parameter is set to False," | ||
| " while bucket iterators by definition change the order of your data.") | ||
| # else: |
There was a problem hiding this comment.
Yes, this should be a comment in the code inside the if shuffle block, like # NOTE: if shuffle is false, the data will still be in a different order because of the bucket sorting. We generally don't allow commented-out code to be checked in, because it's not obvious why the code is commented out.
There was a problem hiding this comment.
Sure. So I believe that you mean to remove the else block code and replace the if block by the following:
if shuffle:
# NOTE: if shuffle is false, the data will still be in a different order
# because of the bucket sorting
random.shuffle(batches)right?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From discussion here: #1578. Let me know if I should remove the code instead of commenting it.