This repository was archived by the owner on Dec 16, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Remove large openie model file #1756
Merged
matt-gardner
merged 20 commits into
allenai:master
from
gabrielStanovsky:remove-large-openie-model-file
Sep 12, 2018
Merged
Remove large openie model file #1756
matt-gardner
merged 20 commits into
allenai:master
from
gabrielStanovsky:remove-large-openie-model-file
Sep 12, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
- Remove large Open IE model file (~30mb), which was pushed accidentally.
- Use SRL's fixture model instead, in testing the Open IE predictor.
…span_metric` parameter to the SRL model to accomodate for Open IE
Addresses #1754 |
matt-gardner
approved these changes
Sep 12, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Hi team, this file still exists in the git history. To remove it entirely, the admin could follow this and this guides. The change requires
|
@huntzhan thanks for bringing this up --- the decision was made to not change the git history through force-pushing (also see #1757 (comment)) |
@nelson-liu got it, thank you for your clarification. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.