This repository was archived by the owner on Dec 16, 2022. It is now read-only.
sql data updates #1827
Merged
sql data updates #1827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-gardner
approved these changes
Sep 27, 2018
| def split_table_and_column_names(table: str) -> Iterable[str]: | ||
|
|
||
| partitioned = [x for x in table.partition(".") if x != ''] | ||
| if partitioned[0].isnumeric() and partitioned[-1].isnumeric(): |
There was a problem hiding this comment.
What case is this handling? I'm having a hard time guessing what this logic accomplishes without having looked at the data.
| previous_token = sql_tokens[0] | ||
| for (token, next_token) in zip(sql_tokens[1:-1], sql_tokens[2:]): | ||
| if token == "AS" and previous_token is not None: | ||
| table_name = next_token[:-6] |
There was a problem hiding this comment.
This is removing the "aliasX" bit, right? Some comment about that would be nice here (as a comment or a docstring).
| '=', 'LOCATION', '.', 'RESTAURANT_ID', 'AND', 'RESTAURANT', '.', 'NAME', '=', "'name0'", ';'] | ||
|
|
||
| # Check we don't mangle decimal numbers: | ||
| assert text2sql_utils.clean_unneeded_aliases(["2.5"]) == ["2.5"] |
There was a problem hiding this comment.
Ah, I see, that bit above makes sense now. A brief comment would be nice.
| cleaned = text2sql_utils.clean_unneeded_aliases(sql) | ||
| assert cleaned == ['SELECT', 'COUNT', '(', '*', ')', 'FROM', 'LOCATION', ',', 'RESTAURANT', 'WHERE', | ||
| 'LOCATION', '.', 'CITY_NAME', '=', "'city_name0'", 'AND', 'RESTAURANT', '.', 'ID', | ||
| '=', 'LOCATION', '.', 'RESTAURANT_ID', 'AND', 'RESTAURANT', '.', 'NAME', '=', "'name0'", ';'] |
There was a problem hiding this comment.
It's probably worth adding a test here with a case where you shouldn't remove the "AS", just to be sure we handle those correctly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASstatements to the scriptTABLE.COLUMN -> TABLE . COLUMN