This repository was archived by the owner on Dec 16, 2022. It is now read-only.
Simplified GrammarStatelet, made a new LambdaGrammarStatelet class for WikiTables #1829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-gardner
commented
Oct 2, 2018
| from allennlp.nn import util | ||
|
|
||
|
|
||
| # We're not actually inhereting from `GrammarStatelet` here because there's very little logic that |
There was a problem hiding this comment.
This class is basically unmodified from the previous GrammarStatelet. The only things that are different are the docstrings and this comment.
pku-wuwei
added a commit
to pku-wuwei/allennlp
that referenced
this pull request
Oct 3, 2018
…class for WikiTables (allenai#1829)" This reverts commit d8b13e0.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In writing a tutorial for the framework, I decided that we really don't need to worry about lambdas in the main
GrammarStateletclass. So I made a new one that handled lambdas, and greatly simplified the main one. @OyvindTafjord @rajasagashe, this just means that when you create your initial state, you don't need to pass in empty objects for thelambda_stacksandcontext_actionsarguments, because those arguments are now gone. Nothing else in your code should have to change.