This repository was archived by the owner on Dec 16, 2022. It is now read-only.
Use current_log_probs instead of log_probs in debug_info #1855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pku-wuwei
added a commit
to pku-wuwei/allennlp
that referenced
this pull request
Oct 3, 2018
…enai#1855)" This reverts commit 1d50292.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the probabilities shown in the demo for any semantic parser are cumulative probabilities, not current probabilities for a specific action, so the distribution didn't sum to one, which was confusing. This PR fixes that. FYI @OyvindTafjord.