8000 Raise RuntimeError if java is not available by seal6363 · Pull Request #1856 · allenai/allennlp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Dec 16, 2022. It is now read-only.

Raise RuntimeError if java is not available #1856

Merged
merged 4 commits into from
Oct 2, 2018
Merged

Raise RuntimeError if java is not available #1856

merged 4 commits into from
Oct 2, 2018

Conversation

seal6363
Copy link
Contributor
@seal6363 seal6363 commented Oct 2, 2018 •
edited
Loading

closes #1850

joelgrus
joelgrus approved these changes Oct 2, 2018
View reviewed changes
Copy link
Contributor
@joelgrus joelgrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, can you just change the title of the PR to something more descriptive like "raise RuntimeError if java is not available" or something like that

@seal6363 seal6363 changed the title add check function in verify.py Raise RuntimeError if java is not available Oct 2, 2018
@joelgrus joelgrus merged commit 358c36b into allenai:master Oct 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joelgrus joelgrus joelgrus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a clearer issue when the JVM isn't available
2 participants
@seal6363 @joelgrus
0