This repository was archived by the owner on Dec 16, 2022. It is now read-only.
Add a --force command to train #1913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-gardner
approved these changes
Oct 16, 2018
allennlp/commands/train.py
Outdated
| if os.path.exists(serialization_dir) and os.listdir(serialization_dir): | ||
| if not recover: | ||
| if force: |
There was a problem hiding this comment.
The level of nesting that this gets to is scary. I also think you can avoid it - what if you just move the remove block up above, and leave the rest of the code unmodified? That is, have something like:
if recover and force:
raise ...
if force:
shutil.rmtree(serialization_dir)
... # the rest of the code unchangedThere was a problem hiding this comment.
Yeah--I'm fine with that.
|
If I omit the exists check then I need to tell |
|
Yeah, keeping that exists check is fine, I was more commenting on pulling out that branch to up above, not on the specifics of the code block. Looks like you forgot to move back the main logic that you changed, though. |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1575