This repository was archived by the owner on Dec 16, 2022. It is now read-only.
Fix for import_submodules #1976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000
joelgrus
reviewed
Oct 26, 2018
allennlp/common/util.py
Outdated
| for module_finder, name, _ in pkgutil.walk_packages(path): | ||
| # Sometimes when you import third-party libraries that are on your path, | ||
| # `pkgutil.walk_packages` returns those too, so we need to skip them. | ||
| if path_string and module_finder.path not in path_string: |
There was a problem hiding this comment.
what's the reasoning for the in instead of ==?
There was a problem hiding this comment.
Me doing a cursory look at the strings and not realizing they were equal instead of a substring... =)
joelgrus
approved these changes
Oct 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm really not sure what circumstance led me to run into this, but this change fixed the problem. I don't understand why others haven't run into this issue; maybe it's because I was using
allennlpjust in myPYTHONPATH, instead of installing it through pip?The exact command I was running was: